You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
RFPImp is relied on quite a bit by LUMIN, however it imports stuff from sklearn.ensemble.forest, which is depreciated since 0.22, and will be removed in 0.24. Currently this raises FutureWarning. Hopefully in the next release this will be fixed and we can upgrade LUMIN to use the new version of RFPImp.
The text was updated successfully, but these errors were encountered:
GilesStrong
added
medium priority
Not urgent but should be dealt with sooner rather than later
wait
Something that relies on something else occurring first
bug
Something isn't working
high priority
Something which is urgent
and removed
medium priority
Not urgent but should be dealt with sooner rather than later
labels
Jun 9, 2020
Latest release of rfpimp only checks if sklearn version is 0.22 when performing compatibility checks. Results in crashes when trying to use auto_filter_on_mutual_dependence due to _generate_unsampled_indices requiring 3 arguments in sklearn >= 0.22.
Quick fix is to replace if sklearn.__version__.startswith("0.22"): with if LooseVersion(sklearn.__version__) >= LooseVersion("0.22"): and add from distutils.version import LooseVersion to the imports.
Spotted that scikit-learn==0.22.2 meets all the requirements for LUMIN and rfpimp==1.3.5 successfully uses appropriate scikit-learn private API. Adjusted requirements to these versions.
RFPImp is relied on quite a bit by LUMIN, however it imports stuff from sklearn.ensemble.forest, which is depreciated since 0.22, and will be removed in 0.24. Currently this raises
FutureWarning
. Hopefully in the next release this will be fixed and we can upgrade LUMIN to use the new version of RFPImp.The text was updated successfully, but these errors were encountered: