Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventual upgrade of RFPImp version #80

Open
GilesStrong opened this issue Jun 9, 2020 · 2 comments
Open

Eventual upgrade of RFPImp version #80

GilesStrong opened this issue Jun 9, 2020 · 2 comments
Labels
wait Something that relies on something else occurring first

Comments

@GilesStrong
Copy link
Owner

RFPImp is relied on quite a bit by LUMIN, however it imports stuff from sklearn.ensemble.forest, which is depreciated since 0.22, and will be removed in 0.24. Currently this raises FutureWarning. Hopefully in the next release this will be fixed and we can upgrade LUMIN to use the new version of RFPImp.
@GilesStrong GilesStrong added medium priority Not urgent but should be dealt with sooner rather than later wait Something that relies on something else occurring first bug Something isn't working high priority Something which is urgent and removed medium priority Not urgent but should be dealt with sooner rather than later labels Jun 9, 2020
@GilesStrong
Copy link
Owner Author

Latest release of rfpimp only checks if sklearn version is 0.22 when performing compatibility checks. Results in crashes when trying to use auto_filter_on_mutual_dependence due to _generate_unsampled_indices requiring 3 arguments in sklearn >= 0.22.

Quick fix is to replace if sklearn.__version__.startswith("0.22"): with if LooseVersion(sklearn.__version__) >= LooseVersion("0.22"): and add from distutils.version import LooseVersion to the imports.

@GilesStrong
Copy link
Owner Author

Spotted that scikit-learn==0.22.2 meets all the requirements for LUMIN and rfpimp==1.3.5 successfully uses appropriate scikit-learn private API. Adjusted requirements to these versions.

@GilesStrong GilesStrong removed bug Something isn't working high priority Something which is urgent labels Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wait Something that relies on something else occurring first
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GilesStrong