extract require utils in rules

EmmanuelDemey · Dec 6, 2015 · 2aa5400 · 2aa5400
1 parent dcfff4a
commit 2aa5400
Show file tree

Hide file tree

Showing 27 changed files with 53 additions and 28 deletions.
diff --git a/rules/controller-as-route.js b/rules/controller-as-route.js
@@ -9,8 +9,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     return {
         CallExpression: function(node) {

diff --git a/rules/controller-as-vm.js b/rules/controller-as-vm.js
@@ -11,8 +11,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
     var badStatements = [];
     var badCaptureStatements = [];
     var controllerFunctions = [];

diff --git a/rules/controller-as.js b/rules/controller-as.js
@@ -11,8 +11,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
     var badStatements = [];
     var controllerFunctions = [];
 

diff --git a/rules/controller-name.js b/rules/controller-name.js
@@ -12,8 +12,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     return {
 

diff --git a/rules/di.js b/rules/di.js
@@ -8,8 +8,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     var angularNamedObjectList = ['value', 'factory', 'service', 'provider', 'controller', 'filter', 'directive'];
 

diff --git a/rules/directive-name.js b/rules/directive-name.js
@@ -12,8 +12,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
     if (context.settings.angular === 2) {
         return {};
     }

diff --git a/rules/directive-restrict.js b/rules/directive-restrict.js
@@ -12,8 +12,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     var options = context.options[0] || {};
     var restrictOpt = options.restrict || 'AE';

diff --git a/rules/empty-controller.js b/rules/empty-controller.js
@@ -9,8 +9,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     function report(node, name) {
         context.report(node, 'The {{ctrl}} controller is useless because empty. You can remove it from your Router configuration or in one of your view', {

diff --git a/rules/file-name.js b/rules/file-name.js
@@ -13,8 +13,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = (function() {
-    var utils = require('./utils/utils');
     var path = require('path');
     var fileEnding = '.js';
 

diff --git a/rules/filter-name.js b/rules/filter-name.js
@@ -10,8 +10,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     return {
 

diff --git a/rules/function-type.js b/rules/function-type.js
@@ -12,8 +12,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
     var angularObjectList = ['animation', 'config', 'constant', 'controller', 'directive', 'factory', 'filter', 'provider', 'service', 'value', 'decorator'];
     var configType = context.options[0] || 'anonymous';
     var messageByConfigType = {

diff --git a/rules/module-dependency-order.js b/rules/module-dependency-order.js
@@ -14,8 +14,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     var options = context.options[0] || {};
     var groupedMode = options.grouped !== false;

diff --git a/rules/module-getter.js b/rules/module-getter.js
@@ -10,8 +10,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     return {
 

diff --git a/rules/module-name.js b/rules/module-name.js
@@ -11,8 +11,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     return {
 

diff --git a/rules/module-setter.js b/rules/module-setter.js
@@ -10,9 +10,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
 
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     return {
 

diff --git a/rules/no-controller.js b/rules/no-controller.js
@@ -8,8 +8,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     return {
 

diff --git a/rules/no-service-method.js b/rules/no-service-method.js
@@ -9,8 +9,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     return {
 

diff --git a/rules/no-services.js b/rules/no-services.js
@@ -12,8 +12,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     var angularObjectList = ['controller', 'filter', 'directive'];
     var badServices;

diff --git a/rules/rest-service.js b/rules/rest-service.js
@@ -9,8 +9,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     var angularObjectList = ['controller', 'filter', 'directive', 'service', 'factory', 'provider'];
     var services = ['$http', '$resource', 'Restangular'];

diff --git a/rules/service-name.js b/rules/service-name.js
@@ -11,8 +11,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     return {
 

diff --git a/rules/typecheck-array.js b/rules/typecheck-array.js
@@ -8,8 +8,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     function recordError(node, origin) {
         if (node.type === 'Literal' && node.value === '[object Array]') {

diff --git a/rules/typecheck-date.js b/rules/typecheck-date.js
@@ -8,8 +8,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     function recordError(node, origin) {
         if (node.type === 'Literal' && node.value === '[object Date]') {

diff --git a/rules/typecheck-function.js b/rules/typecheck-function.js
@@ -8,8 +8,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     function recordError(node, origin) {
         if (node.type === 'Literal' && (node.value === 'function' || node.value === '[object Function]')) {

diff --git a/rules/typecheck-number.js b/rules/typecheck-number.js
@@ -8,8 +8,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     function recordError(node, origin) {
         if (node.type === 'Literal' && (node.value === 'number' || node.value === '[object Number]')) {

diff --git a/rules/typecheck-object.js b/rules/typecheck-object.js
@@ -8,8 +8,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     function recordError(node, origin) {
         if (node.type === 'Literal' && (node.value === 'object' || node.value === '[object Object]')) {

diff --git a/rules/typecheck-regexp.js b/rules/typecheck-regexp.js
@@ -9,8 +9,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
 
     function recordError(node, origin) {
         if (node.type === 'Literal' && node.value === '[object RegExp]') {

diff --git a/rules/typecheck-string.js b/rules/typecheck-string.js
@@ -8,9 +8,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     function recordError(node, origin) {
         if (node.type === 'Literal' && (node.value === 'string' || node.value === '[object String]')) {
             context.report(origin, 'You should use the angular.isString method', {});