Issue #472 timeout service fail on jasmine.getGlobal().setTimeout

EmmanuelDemey · May 27, 2017 · a696f99 · a696f99
1 parent ee57435
commit a696f99
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/rules/timeout-service.js b/rules/timeout-service.js
@@ -20,7 +20,7 @@ module.exports = {
         return {
 
             MemberExpression: function(node) {
-                if (node.property.name !== 'setTimeout') {
+                if (node.property.name !== 'setTimeout' || !node.object) {
                     return;
                 }
 
@@ -35,6 +35,10 @@ module.exports = {
                 // Detect expression this.$window.setTimeout which is what we would see in ES6 code when using classes
                 var parentNode = node.object;
 
+                if (!parentNode.object) {
+                    return;
+                }
+
                 if (parentNode.object.type === 'ThisExpression' && parentNode.property.name === '$window') {
                     context.report(node, message, {});
                 }

diff --git a/test/timeout-service.js b/test/timeout-service.js
@@ -18,6 +18,7 @@ var message = 'You should use the $timeout service instead of the default window
 
 eslintTester.run('timeout-service', rule, {
     valid: [
+        'jasmine.getGlobal().setTimeout',
         '$timeout(function() {})',
         '$timeout(function() {}, 1000)',
         '$timeout(function() {}, 1000, true)',