Issue #476 foreach rule doesn't work for arrays in object property

EmmanuelDemey · Jun 3, 2017 · f294fb1 · f294fb1
1 parent 6621eee
commit f294fb1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/rules/foreach.js b/rules/foreach.js
@@ -16,7 +16,7 @@ module.exports = {
     create: function(context) {
         return {
             MemberExpression: function(node) {
-                if (node.object.type === 'Identifier' && node.object.name !== 'angular' && node.property.name === 'forEach') {
+                if (node.object.name !== 'angular' && node.property.name === 'forEach') {
                     context.report(node, 'You should use the angular.forEach method', {});
                 }
             }

diff --git a/test/foreach.js b/test/foreach.js
@@ -18,6 +18,7 @@ eslintTester.run('foreach', rule, {
         'angular.forEach(variable, function() {})'
     ].concat(commonFalsePositives),
     invalid: [
-        {code: 'variable.forEach(function() {})', errors: [{message: 'You should use the angular.forEach method'}]}
+        {code: 'variable.forEach(function() {})', errors: [{message: 'You should use the angular.forEach method'}]},
+        {code: 'a.b.forEach(function() {})', errors: [{message: 'You should use the angular.forEach method'}]}
     ]
 });