Fix: Guard against 'null' description when losing focus (fixes #19) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue where if you search and render suggestions for the first time (i.e. a suggestion hasn't been selected yet) and click away so taht focus is lost then you will receive an error of the form: "Uncaught TypeError: Cannot read property 'description' of null". This error occurs in the function we pass to the 'itemToString' prop when rendering the <Downshift> component. Its a result of no suggestions being available yet trying to destructure the 'description' property off of a suggestion. This commit provides a fix to guard against the case where there are no suggestions, in which case we simply return the empty string. modified: src/MUIPlacesAutocomplete.jsx
mattbailey
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue where if you search and render suggestions for the first time (i.e. a suggestion hasn't been selected yet) and click away so that focus is lost then you will receive an error of the form: "Uncaught TypeError: Cannot read property 'description' of null".
This error occurs in the function we pass to the 'itemToString' prop when rendering the component. Its a result of no suggestions being available yet trying to destructure the 'description' property off of a suggestion.
This commit provides a fix to guard against the case where there are no suggestions, in which case we simply return the empty string.
This PR fixes bug: #19