-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It would be nice if GINJ accepted inverted commas. I am pretty sure that Jing did. #53
Comments
It would be nice if GINJ accepted inverted commas. I am pretty sure that Jing did. |
Hi Vicne,
Yes, I was talking about double quotes. In previous version I could never save if there were double quotes in the text and have studiously avoided them ever since.
If it now works it will be wonderful. I will check when GINJ is working again.
Sorry I won’t bring up issues again that are already logged. I felt that if you got the issue more than once and from more than one person you would be in a better position to evaluate priorities.
Best Wishes
Dennis
|
Err, maybe I didn't understand what you mean by "accept". When looking at the log, Ginj indeed does not perform any "cleanup" on the capture name before passing it to the filename selection box, and that causes an error:
I'll add a "cleanup" phase to make sure forbidden characters are replaced before saving. Thanks. |
Hi Vicne,
Thank you.
Yes, the problem was in copying part of the text which had double quotes in the Text box and pasting it into the filename. Because I got an error I assumed it was a GINJ error and didn’t look any further. Only after your message did I test and confirm that the double quotes in the filename were the problem. Thanks again,
Clearing that up will make it much nicer.
See note (in red) below.
Best Wishes
Dennis Polack
It appears that a clean-up never occurs. Once the error has occurred. I sure that the error was not originally caused by double quotes because I have studiously avoided double quotes since I assumed they caused a problem in GINJ. As you can see, my feedback was after I ran the tests in using double quotes.
The error we are now experiencing does not clear itself whereas in the past it worked fine if you tried again.
|
Hi Dennis, Can you try the latest (0.4.8) version to see if it solves the issue ? Also, please reply on the Github website and not by e-mail, because Github only imports basic text from e-mails (no attachments, no font color etc.) Kind regards, |
Hi Vicne, Thank you - Works perfectly now after restart. Thanks again Best Wishes for a Merry Christmas and a Healthy and Rewarding New Year. |
Thanks for reporting the issue, testing and confirming it's now OK. Best wishes to you and your loved ones. |
It would be nice if GINJ accepted inverted commas. I am pretty sure that Jing did.
The text was updated successfully, but these errors were encountered: