Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vectorized form and property API #349

Open
non-Jedi opened this issue Apr 19, 2019 · 1 comment
Open

Remove vectorized form and property API #349

non-Jedi opened this issue Apr 19, 2019 · 1 comment

Comments

@non-Jedi
Copy link

Since any function call can now be called in a "vectorized" form using broadcast syntax, the vectorized form and property methods should now be deprecated for the sake of maintainability. In some scenarios, the broadcasted form should perform better than the current vectorized form due to automatic broadcast fusion. Obviously, this is a breaking change, and many call sites in Gadfly would need to be updated simultaneously with this change.

@Mattriks
Copy link
Member

Note that Compose's vectorised form produces a Compose.Form{<:Compose.FormPrimitive}. Broadcasting a form e.g. ellipse.([0.5], [0.5], [0.1,0.2,0.3], [0.3,0.2,0.1]) produces an Array of forms, which is not the same thing.

Also see #163, which was a previous attempt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants