Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search under the Text category, the result contains the option of "More by...", long press will crash #139

Closed
cuizhihao1994 opened this issue Jul 13, 2021 · 12 comments

Comments

@cuizhihao1994
Copy link

Search something under the Text tab, for example search “Alphabet”, the first search result will show "More by..."
This will appear every other paragraph in the search results. No response to click it, long press will crash.

image

image

@ALexanderLonsky
Copy link
Collaborator

@cuizhihao1994 hey, thank you for flagging this.

Please try this version: implementation "com.giphy.sdk:ui:2.1.3-alpha"

For that, add
maven("https://oss.sonatype.org/content/repositories/staging")
to
repositories

I've added a new property enableDynamicText to GiphyGridView, by default it's disabled.
That thing More by is called GIPHY Animated Text Creation, you can read more about it here

Long press and click actions must be fixed too.

@cuizhihao1994
Copy link
Author

@ALexanderLonsky Thanks for your guidance.

After we upgraded the version from 2.0.9 to 2.1.2, the above problem did not appear temporarily. However, ExoPlayer in version 2.1.2 will conflict with the old version of exoplayer in our program. What is the version of exoplayer in the latest SDK? We plan to update it.

@ALexanderLonsky
Copy link
Collaborator

@cuizhihao1994 we've updated to 2.13.3 to totally get off of JCenter.

You can try to resolve conflicting dependencies using
resolutionStrategy/force to point to the proper dependency version

@cuizhihao1994
Copy link
Author

@ALexanderLonsky Thanks for your patience, but we found that the above-mentioned problem also exists in the SDK 2.1.2 version. We tried to test with the 2.1.3-alpha version, but when entering the search interface, the 2.1.3 version would directly crash.

By the way, we tried a key from other developers, and the above problem did not occur. But our own key will have this problem. Excuse me, is there any problem with our key? Key has been updated to the release version.

@ALexanderLonsky
Copy link
Collaborator

@cuizhihao1994 this is weird.
Could you please drop here the crash log?

Also, our Example app provides GiphyGridView sample. There is a grid button to the left of the settings button. There you can launch text grid.
Does it crash for you?
I think a key shouldn't be a cause.

@cuizhihao1994
Copy link
Author

@ALexanderLonsky The log for crash:

log (2).txt

@ALexanderLonsky
Copy link
Collaborator

@cuizhihao1994
can you try please:
File > Invalidate Cache & Restart
image

@cuizhihao1994
Copy link
Author

@ALexanderLonsky Thank you again for your patient answers. We tried the 2.1.3-alpha version of the SDK, and the above problem did not reappear. But we feel that this version is not very stable and often crashes during testing (I have attached a new log file below).

When will the official version of 2.1.3 be released? There are many users of our products, so we hope to adopt a more stable version.
crash.txt

@ALexanderLonsky
Copy link
Collaborator

@cuizhihao1994 actually, this version differs from the stable one only in Animated Text feature for GiphyGridView.
I've fixed only that and long-press/tap gestures for the animated texts.

The new crash you have found is a different one. I can not reproduce it on my end but the crash log was helpful and I fixed that.
Here is a new version:
implementation "com.giphy.sdk:ui:2.1.3-beta"
It's still staging and requires maven("https://oss.sonatype.org/content/repositories/staging")

Could you please try it out?
I hope this one is crash-free.

Thank you for your assistance!

P.S. You can go live with 2.1.3-beta if it works well for you, I'll release the official 2.1.3 later on, right now we don't plan to do any improvements, that's why it won't differ from 2.1.3-beta unless you find anything else I can help with.

@cuizhihao1994
Copy link
Author

@ALexanderLonsky Sorry to disturb you again, we can only access the 2.1.3-beta version in GIPHY's Demo. We cannot access this version in our program. The error message is as follows:

A problem occurred configuring root project

Could not resolve all artifacts for configuration ':classpath'.
Could not find com.novoda:bintray-release:0.8.0.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/com/novoda/bintray-release/0.8.0/bintray-release-0.8.0.pom
- https://dl.google.com/dl/android/maven2/com/novoda/bintray-release/0.8.0/bintray-release-0.8.0.pom
Required by:
project :
Could not find com.bytedance.android:aabresguard-plugin:0.1.8.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/com/bytedance/android/aabresguard-plugin/0.1.8/aabresguard-plugin-0.1.8.pom
- https://dl.google.com/dl/android/maven2/com/bytedance/android/aabresguard-plugin/0.1.8/aabresguard-plugin-0.1.8.pom
Required by:
project :

Possible solution:

@ALexanderLonsky
Copy link
Collaborator

@cuizhihao1994
I don't think it's related to our SDK.
implementation "com.giphy.sdk:ui:2.1.3-beta" only requires to add

Groovy:

repositories {
    maven {
        url 'https://oss.sonatype.org/content/repositories/staging'
    }
}

Kotlin:

repositories {
    maven("https://oss.sonatype.org/content/repositories/staging")
}

novoda is a different thing, it seems they require to add this:

repositories {
    maven {
        url 'https://dl.bintray.com/novoda-oss/snapshots/'
    }
}

here it is: novoda/bintray-release/0.8.0

android:aabresguard is not related to our SDK too:
aabresguard-plugin/0.1.8

It seems this artifact is located at JCenter,
you should add

 repositories {
    jcenter()
}

@ALexanderLonsky
Copy link
Collaborator

stable version 2.1.3 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants