Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dimBackground does not work #16

Closed
h36ahmed opened this issue Aug 16, 2019 · 4 comments
Closed

dimBackground does not work #16

h36ahmed opened this issue Aug 16, 2019 · 4 comments

Comments

@h36ahmed
Copy link

I wanted to remove dimming of background but setting the boolean to false on the giphy controller did not remove the background. Could you take a look at it?

@h36ahmed h36ahmed changed the title DimBackground does not work dimBackground does not work Aug 16, 2019
@cgmaier
Copy link
Contributor

cgmaier commented Aug 16, 2019

hi @h36ahmed nice catch! we'll fix this in our next release

in the meantime, you should be able to disable background dimming with

giphyViewController.transitioningDelegate = nil 

this will bypass the custom view controller presentation animation which is responsible for the dimming.

thanks for your help!

@h36ahmed
Copy link
Author

Awesome, thanks for the fix.

@cgmaier
Copy link
Contributor

cgmaier commented Aug 27, 2019

hey @h36ahmed we fixed this in the latest release
thanks again for the catch

@h36ahmed
Copy link
Author

Confirmed fix

@cgmaier cgmaier closed this as completed Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants