Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giphy React Grid component is not working #301

Closed
2 tasks done
rimildeyjsr opened this issue Jun 27, 2022 · 4 comments 路 Fixed by #302
Closed
2 tasks done

Giphy React Grid component is not working #301

rimildeyjsr opened this issue Jun 27, 2022 · 4 comments 路 Fixed by #302
Labels
bug Something isn't working

Comments

@rimildeyjsr
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 馃槸

I am trying to replicate the search and masonry grid from the official documentation using their Codesandbox example.

However, when I am trying to use it, the code is not returning any gifs back.

I have verified that the JS fetch is indeed returning back gifs, it seems that the grid is not calling the fetchGifs function.

I am hitting the same issue with Carousel component as well.

Codesandbox link for my implementation - https://codesandbox.io/s/cocky-waterfall-ny9rzk Component i was trying to use - Search and Grid from https://github.com/Giphy/giphy-js/tree/master/packages/react-components

Expected behavior 馃

The grid and carousel should return gifs

Steps to reproduce 馃暪

https://codesandbox.io/s/cocky-waterfall-ny9rzk

Screenshots or Videos 馃摴

No response

Platform 馃實

MacOS, Chrome

GIPHY-JS SDK version

5.9.2

TypeScript version

4.6.4

Additional context 馃敠

No response

@giannif
Copy link
Collaborator

giannif commented Jun 27, 2022

@rimildeyjsr not sure why but it has to do with <StrictMode/>, which is wrapping the app in the index.tsx file

We will investigate. In the meantime, if you remove StrictMode it will work.

@rimildeyjsr
Copy link
Author

Thank you for looking into this @giannif!

@giannif
Copy link
Collaborator

giannif commented Jun 29, 2022

@rimildeyjsr thanks for catching the issue! I just released @giphy/react-components version 5.9.3 with this fix and the codesandbox works with this new version 馃拑

@rimildeyjsr
Copy link
Author

@giannif - Thank you for the quick fix! I verified as well it works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants