Add GUI prompts for GitLab authentication #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add shared UI project for GitLab. Project contains the shared view models and commands for the main auth prompt.
Implement an Avalonia-based UI helper for GitLab and include this in Mac and Linux packages/installers.
Implement a WPF-based UI helper for GitLab and include this in the Windows installers.
Invoke the GitLab UI helper if the current session is GUI interactive, the user has not disabled GUI prompts, and the helper is found.
mjcheetham
added
enhancement
mjcheetham
requested review from
derrickstolee,
vtbassmatt,
jeffhostetler and
ldennington
vtbassmatt
approved these changes
Feb 9, 2022
derrickstolee
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Looks good. Do we want @hickford to give this a quick test?
hickford
suggested changes
Feb 9, 2022
Works for me. |
hickford
suggested changes
Feb 9, 2022
On custom GitLab instances, don't show the GitLab "fox" logo, only the logotype. We also replace the old PNG logo with SVG/vector versions for better display on high-resolution displays. Ensure we only show the "sign up" link for GitLab.com fix wpf
Pass the instance URL argument to the GitLab UI helper.
|
New screenshots with SVG-based logo and logotype, as well as for gitlab.com and custom instances (for both Avalonia and WPF implementations).
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GUI prompts on all platforms for GitLab authentication. GUI prompts are required because if GCM/Git is invoked from an IDE without a terminal, there is no way for the user to authenticate for GitLab.
Note that if the host is "gitlab.com" then the instance name is not shown.
The "Sign Up" link takes you to https://about.gitlab.com.