New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run pod install on Example #41
Conversation
Won’t this require a pod install to get examples working now? I’d like the repo to all work just by downloading. Sent with GitHawk |
@rnystrom yeah it would, best practise is not to checkin |
Main reason is they can be generated, checking them in will lead to merge conflicts and other issues down the line, its an unnecessary pain point for engineers - this generally outweighs people having to have I believe the issue why Carthage isn't able to build this is that its detecting a Another reason not to checkin generated code ;-) I can update the diff with a fix for the cocoa pods issue if thats how you'd prefer to keep it. |
Ya if rather keep this repo inline with the others instead of introduce another maintenance model. If were gonna do this, wed want to do it to everything (and I’m not convinced it matters after maintaining large OSS work with checked-in Pods for 3 years). IMO let’s just do the minimal fix to make Cartage work. Sent with GitHawk |
Sounds good, just ran |
Thank you! Sent with GitHawk |
Ah sorry, used the latest release but it does not include this change :) So with this commit it works. 👍 |
Will update! Sent with GitHawk |
Example.xcworkspace
is generated bypod install
so there is no need to check it in. Removing this allowscarthage install
to work again with Swift 4.2If
Carthage
detects that there is a.workspace
then it will try build that instead ofContextMenu.xcodeproj
.