Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not respecting bottom inset when adjusting offset for keyboard #70

Closed
rnystrom opened this issue Aug 12, 2018 · 2 comments
Closed

Not respecting bottom inset when adjusting offset for keyboard #70

rnystrom opened this issue Aug 12, 2018 · 2 comments
Assignees
Labels

Comments

@rnystrom
Copy link
Member

I knew something was off. Fixed locally will push.

Sent with GitHawk

@rnystrom rnystrom added the bug label Aug 12, 2018
@rnystrom rnystrom self-assigned this Aug 12, 2018
@siefix
Copy link

siefix commented Aug 30, 2018

Is there any way to make this respect the tabBar (if you have one?)

The only way I found for it to adjust for the tab bar is with
tabBarController?.tabBar.isHidden = true

However if you use something like (animatable)
tabBarController?.tabBar.frame.origin = CGPoint(x: 0, y: frameHeight - tabBarHeight)

The messageView will still show the extra 49pts of tabbarheight

Or.....any insight into how Instagram does it?! :) (not sure if you use MessageViewController)

Looks like you might be doing present(_:animated:completion:) instead of pushViewController(_ viewController: UIViewController, animated: Bool) and then are using some sort of custom right/left UIViewControllerAnimatedTransitioning?

img_5203

@rnystrom
Copy link
Member Author

@siefix can you open a new issue? This was fixed, I forgot to close (can’t find hash while traveling).

Instagram doesn’t use this 😉

Sent with GitHawk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants