Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] MsBuild fails when not in a git repo (GitHub ZIP download) #3242

Closed
0blu opened this issue Oct 19, 2022 · 1 comment
Closed

[Bug] MsBuild fails when not in a git repo (GitHub ZIP download) #3242

0blu opened this issue Oct 19, 2022 · 1 comment
Labels

Comments

@0blu
Copy link

0blu commented Oct 19, 2022

When downloading a repository as a ZIP from GitHub the build process fails, because there is no repository (.git folder) in the zip.

image

I read something about a fallback strategy in the unreleased breaking_changes.md.
Will this fix the issue?

Expected Behavior

There should be an option to default the version to 0.0.0 when no repository is found.

Steps to Reproduce

This bug was tested with HermesProxy but applies to all other projects too.

  1. Use GitHub to download the project as a zip
  2. Try to compile the solution

Your Environment

  • GitVersion.MsBuild: 5.10.3
  • Windows 10
@0blu 0blu added the bug label Oct 19, 2022
@asbjornu
Copy link
Member

asbjornu commented Oct 19, 2022

I believe this was fixed in #3190 which will be a part of v6 once it's released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants