You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
resolve-pathname has been released as 2.2.0, which introduces ES6 exports. While urljoin.js still works in a NodeJS environment, it won't work when bundled with Webpack. That's because Webpack prefers to load the file referenced in the package.json's "module" which is an ES6 version. The result is that require('resolve-pathname') resolves to { default: Function }.
We can whether change the version urljoin.js depends on (from resolve-pathname@^2.1.0 to resolve-pathname@2.1.0) or rewrite it as ES6 and publish a version compiled with Webpack.
The text was updated successfully, but these errors were encountered:
zhouzi
changed the title
Latest version of resolve-pathname broke this package
Latest version of resolve-pathname broke urljoin.js
Nov 13, 2017
resolve-pathname
has been released as2.2.0
, which introduces ES6 exports. Whileurljoin.js
still works in a NodeJS environment, it won't work when bundled with Webpack. That's because Webpack prefers to load the file referenced in thepackage.json
's"module"
which is an ES6 version. The result is thatrequire('resolve-pathname')
resolves to{ default: Function }
.Related discussions:
module
gets prioritised overmain
webpack/webpack#5756default
exports in ES Modules webpack/webpack#4742We can whether change the version
urljoin.js
depends on (fromresolve-pathname@^2.1.0
toresolve-pathname@2.1.0
) or rewrite it as ES6 and publish a version compiled with Webpack.The text was updated successfully, but these errors were encountered: