Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of resolve-pathname broke urljoin.js #2

Closed
zhouzi opened this issue Nov 13, 2017 · 1 comment
Closed

Latest version of resolve-pathname broke urljoin.js #2

zhouzi opened this issue Nov 13, 2017 · 1 comment
Labels

Comments

@zhouzi
Copy link
Contributor

zhouzi commented Nov 13, 2017

resolve-pathname has been released as 2.2.0, which introduces ES6 exports. While urljoin.js still works in a NodeJS environment, it won't work when bundled with Webpack. That's because Webpack prefers to load the file referenced in the package.json's "module" which is an ES6 version. The result is that require('resolve-pathname') resolves to { default: Function }.

Related discussions:

We can whether change the version urljoin.js depends on (from resolve-pathname@^2.1.0 to resolve-pathname@2.1.0) or rewrite it as ES6 and publish a version compiled with Webpack.

@zhouzi zhouzi changed the title Latest version of resolve-pathname broke this package Latest version of resolve-pathname broke urljoin.js Nov 13, 2017
@zhouzi zhouzi added the bug label Nov 13, 2017
@donaldpipowitch
Copy link

or rewrite it as ES6 and publish a version compiled with Webpack.

That sounds nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants