Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PP] Merge og_ui into the main OG module #396

Open
pfrenssen opened this issue Jun 28, 2018 · 1 comment
Open

[PP] Merge og_ui into the main OG module #396

pfrenssen opened this issue Jun 28, 2018 · 1 comment

Comments

@pfrenssen
Copy link
Contributor

It is no longer making sense to keep these two modules separated. We can safely assume that 80% of the sites that use Organic Groups will need at least some part of the UI in the day-to-day operation of the site.

By merging the two we can meet the needs of most users and avoid the complexity of maintaining two different modules.

@MPParsley
Copy link
Collaborator

MPParsley commented Apr 24, 2019

Postponed on #243.

Note that currently the OgRole entity is defined in 'og' but it contains links to routes defined by 'og_ui':

 *   links = {
 *     "add-form" = "/admin/config/group/roles/{entity_type_id}/{bundle_id}/add",
 *     "edit-form" = "/admin/config/group/role/{og_role}/edit",
 *     "canonical" = "/admin/config/group/role/{og_role}/edit",
 *     "delete-form" = "/admin/config/group/role/{og_role}/delete",
 *   },

This won't work when reinstalling the site from config. Merging og_ui with og would solve this.

@MPParsley MPParsley changed the title Merge og_ui into the main OG module [PP] Merge og_ui into the main OG module May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants