Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the mess in spatial_tools.py #157

Closed
rhugonnet opened this issue Jun 26, 2021 · 5 comments
Closed

Sort the mess in spatial_tools.py #157

rhugonnet opened this issue Jun 26, 2021 · 5 comments
Labels
invalid This doesn't seem right

Comments

@rhugonnet
Copy link
Contributor

Right now it's a bit our "dumper" module.

Looking at what's inside, I think we could split into:

  • a robust_stats.py module, that includes nmad, nd_binning, robust_polynomial_fit, robust_sumsin_fit, subsample, and all related subfunctions
  • move stack_rasters, merge_rasters, merge_bounding_boxes, get_array_and_mask, etc... to geoutils
  • rename spstats into spatial_stats.py for consistency with robust_stats.py
@rhugonnet
Copy link
Contributor Author

@erikmannerfelt @adehecq An opinion on this?

@erikmannerfelt
Copy link
Contributor

I agree on your division! I would like to discuss the robust_stats.py, however, as I interpret "robust" as just another synonym for "good". It would (for me) sound like calling it good_stats.py (as opposed to the bad_stats.py? ;) ). Maybe I'm alone on that opinion? What do you think, @adehecq?

I especially agree on the -> geoutils suggestions.

@rhugonnet
Copy link
Contributor Author

Maybe there's a better subdivision for that module?
For the naming robust, it is the term widely used in statistics for this kind of methods, from a "simple" NMAD to more complex M-L methods like RANSAC (https://en.wikipedia.org/wiki/Robust_statistics).

@adehecq
Copy link
Member

adehecq commented Jun 29, 2021

Ok to move some of the functionalities to geoutils.
Should it be in georaster directly? Right now, it's mostly just one class and not really a lot of other functions, but this can change.

@erikmannerfelt
Copy link
Contributor

CLosed with 226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
Hack 14-15 Oct 2021
Bugs/Features to-do
Development

Successfully merging a pull request may close this issue.

3 participants