Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider Mutex and RwLock implementations #149

Closed
RustomMS opened this issue Oct 6, 2022 · 0 comments
Closed

Reconsider Mutex and RwLock implementations #149

RustomMS opened this issue Oct 6, 2022 · 0 comments
Labels
declined ➖ Declined represents an issue was closed because it was declined perf 🏇 Anything performance related

Comments

@RustomMS
Copy link
Contributor

RustomMS commented Oct 6, 2022 •
edited
Loading

Consider returning to the std::sync::{Mutex, RwLock} implementations in conrast to our current use of parking_lot

Rust 1.62.0 uses futexes directly (parking_lot uses futexes on linux too in addition to a userspace hash table)
https://blog.rust-lang.org/2022/06/30/Rust-1.62.0.html#thinner-faster-mutexes-on-linux
rust-lang/rust#95035 (comment)
https://github.com/matklad/lock-bench

This may require bench marking and other research
@scsmithr scsmithr added the perf 🏇 Anything performance related label Oct 7, 2022
@greyscaled greyscaled closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2022
@greyscaled greyscaled added the declined ➖ Declined represents an issue was closed because it was declined label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
declined ➖ Declined represents an issue was closed because it was declined perf 🏇 Anything performance related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RustomMS @scsmithr @greyscaled