Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error notification from invalid JSON inside .jsbeautifyrc #1106

Closed
emileber opened this issue Aug 1, 2016 · 3 comments
Closed

No error notification from invalid JSON inside .jsbeautifyrc #1106

emileber opened this issue Aug 1, 2016 · 3 comments
Assignees
Milestone

Comments

@emileber
Copy link
Contributor

emileber commented Aug 1, 2016

Description

If the JSON inside the .jsbeautifyrc file is invalid, there's no error notification so you can't know why your .jsbeautifyrc is ignored.

I had a comma at the end of an object definition, which is valid js, but invalid json. I tried the Help Debug Editor option (see below) and then I saw that my .jsbeautifyrc file inside a project sub-folder wasn't interpreted correctly.

Expected behavior

Would be cool if there was an error (or at least a warning) notification when an invalid .jsbeautifyrc file is encountered.

Debug

Here is a link to the debug.md Gist: https://gist.github.com/anonymous/50c9cc5cb71e99a32bb8141365a6e732

@Glavin001 Glavin001 self-assigned this Aug 4, 2016
@Glavin001
Copy link
Owner

I agree.

I am away on vacation for the next two weeks so it is unlikely I will be able to make the appropriate changes and publish. Pull requests welcome back. Thanks.

@emileber
Copy link
Contributor Author

emileber commented Sep 2, 2016

This was merged and published to v0.29.11

@emileber emileber closed this as completed Sep 2, 2016
@Glavin001 Glavin001 added this to the v0.30.0 milestone Sep 2, 2016
@Glavin001
Copy link
Owner

Thanks, @emileber !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants