Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ocp-indent beautifier to an Executable with custom path support #1862

Closed
4 of 5 tasks
AllanWang opened this issue Sep 22, 2017 · 4 comments
Closed
4 of 5 tasks
Assignees
Milestone

Comments

@AllanWang
Copy link

AllanWang commented Sep 22, 2017

This is a follow up on the original PR that adds support for OCaml

Attempting to beautify the file in Windows 10 results in the following:

See ocp-indent installation instructions at https://github.com/Glavin001/atom-beautify#beautifiers or go to https://www.typerex.org/ocp-indent.html
Your program is properly installed if running 'where.exe ocp-indent' in your CMD prompt returns an absolute path to the executable.
Hide Stack Trace
Error: Could not find 'ocp-indent'. The program may not be installed.
    at Function.Executable.commandNotFoundError (file:///C:/Users/[user]/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:276:14)
    at HybridExecutable.Executable.commandNotFoundError (file:///C:/Users/[user]/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:268:18)
    at file:///C:/Users/[user]/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:196:22
    at tryCatcher (C:\Users\[user]\.atom\packages\atom-beautify\node_modules\bluebird\js\release\util.js:16:23)
    at Promise._settlePromiseFromHandler (C:\Users\[user]\.atom\packages\atom-beautify\node_modules\bluebird\js\release\promise.js:512:31)
    at Promise._settlePromise (C:\Users\[user]\.atom\packages\atom-beautify\node_modules\bluebird\js\release\promise.js:569:18)
    at Promise._settlePromise0 (C:\Users\[user]\.atom\packages\atom-beautify\node_modules\bluebird\js\release\promise.js:614:10)
    at Promise._settlePromises (C:\Users\[user]\.atom\packages\atom-beautify\node_modules\bluebird\js\release\promise.js:689:18)
    at Async._drainQueue (C:\Users\[user]\.atom\packages\atom-beautify\node_modules\bluebird\js\release\async.js:133:16)
    at Async._drainQueues (C:\Users\[user]\.atom\packages\atom-beautify\node_modules\bluebird\js\release\async.js:143:10)
    at Async.drainQueues (C:\Users\[user]\.atom\packages\atom-beautify\node_modules\bluebird\js\release\async.js:17:14)
    at process._tickCallback (internal/process/next_tick.js:103:7)

This is expected, as

where.exe ocp-indent

Does not find anything.

I've installed ocp-indent successfully through opam, but it is located in C:\OCaml64\home\[user]\.opam\4.03.0+mingw64\bin and can only be accessed through the OCaml64 terminal.

Checklist

I have:

  • Tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
  • Reloaded (or restarted) Atom to ensure it is not a caching issue
  • Searched through existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues
    so I know this is not a duplicate issue
  • Filled out the Input, Expected, and Actual sections above or have edited/removed them in a way that fully describes the issue.
  • Generated debugging information by executing Atom Beautify: Help Debug Editor command in Atom and added link for debug.md Gist to this issue
@stevenzeck
Copy link
Contributor

I'm trying to get the docker image up and running for ocp-indent. I need to test it out on Windows, but if it works it should be an easy install and run out of the box. I'll provide an update soon.

@Glavin001
Copy link
Owner

What needs to happen is setup ocp-indent as an Executable so custom executable path option is supported.

@Glavin001 Glavin001 changed the title [Question] OCaml support for Windows Convert ocp-indent beautifier to an Executable with custom path support Oct 7, 2017
@stale
Copy link

stale bot commented Dec 6, 2017

This issue has been automatically marked as stale because it has not had recent activity. If this is still an issue, please add a comment. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 6, 2017
@stale stale bot closed this as completed Dec 13, 2017
@Glavin001 Glavin001 reopened this Mar 2, 2018
@stale stale bot removed the stale label Mar 2, 2018
@Glavin001 Glavin001 added this to the v0.32.0 milestone Mar 2, 2018
@Glavin001
Copy link
Owner

Published to v0.32.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants