Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images not being run #1888

Closed
3 of 5 tasks
stevenzeck opened this issue Oct 12, 2017 · 3 comments
Closed
3 of 5 tasks

Docker images not being run #1888

stevenzeck opened this issue Oct 12, 2017 · 3 comments
Assignees
Milestone

Comments

@stevenzeck
Copy link
Contributor

Description

I have Docker installed along with an image of unibeautify/autopep8. When beautifying Python, I get an error stating autopep8 is not installed. From the looks of it, it's trying to go through the cmd line instead of running the docker image. There is an error before it says it could not find autopep8 that looks relevant.

10/12/2017 11:56:53 AM - ./Docker Executable [error]:  TypeError: Cannot read property 'slice' of null
    at Executable.parse [as versionParse] (executable.coffee [sm]:280)
    at executable.coffee [sm]:51
    at tryCatcher (/Users/stevenzeck/Desktop/Development/atom-beautify/node_modules/bluebird/js/release/util.js:16)
    at Promise._settlePromiseFromHandler (/Users/stevenzeck/Desktop/Development/atom-beautify/node_modules/bluebird/js/release/promise.js:512)
    at Promise._settlePromise (/Users/stevenzeck/Desktop/Development/atom-beautify/node_modules/bluebird/js/release/promise.js:569)
    at Promise._settlePromiseCtx (/Users/stevenzeck/Desktop/Development/atom-beautify/node_modules/bluebird/js/release/promise.js:606)
    at Async._drainQueue (/Users/stevenzeck/Desktop/Development/atom-beautify/node_modules/bluebird/js/release/async.js:138)
    at Async._drainQueues (/Users/stevenzeck/Desktop/Development/atom-beautify/node_modules/bluebird/js/release/async.js:143)
    at Async.drainQueues (/Users/stevenzeck/Desktop/Development/atom-beautify/node_modules/bluebird/js/release/async.js:17)
    at process._tickCallback (internal/process/next_tick.js:103)

Input Before Beautification

This is what the code looked like before:

<INSERT CODE HERE>

Expected Output

The beautified code should have looked like this:

Actual Output

The beautified code actually looked like this:

<INSERT CODE HERE>

Steps to Reproduce

  1. Install Docker along with the unibeautify/autopep8 image, restart Atom
  2. Add Python code to Atom editor
  3. Run command Atom Beautify: Beautify Editor
  4. Errors

Debug

Here is a link to the debug.md Gist:

Checklist

I have:

  • Tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
  • Reloaded (or restarted) Atom to ensure it is not a caching issue
  • Searched through existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues
    so I know this is not a duplicate issue
  • Filled out the Input, Expected, and Actual sections above or have edited/removed them in a way that fully describes the issue.
  • Generated debugging information by executing Atom Beautify: Help Debug Editor command in Atom and added link for debug.md Gist to this issue
@stevenzeck
Copy link
Contributor Author

Docker had a couple of recent releases, and docker --version outputs Docker version 17.09.0-ce, build afdb6d4 right now. https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/executable.coffee#L382 doesn't look to recognize the .0 ending to the version.

@stevenzeck
Copy link
Contributor Author

Merged in #1889

@Glavin001 Glavin001 added this to the v0.35.6 milestone Oct 30, 2017
@Glavin001
Copy link
Owner

Published to v0.30.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants