Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML treated as HTML for beautification #197

Closed
bitwiseman opened this issue Jan 30, 2015 · 4 comments
Closed

XML treated as HTML for beautification #197

bitwiseman opened this issue Jan 30, 2015 · 4 comments
Assignees
@Glavin001
Labels
add-language feature
Milestone
v0.25.0

Comments

@bitwiseman
Copy link
Contributor

#3 turned on xml beautification by treating xml as html. That solution is a hack and will be ineffective in a wide variety of cases. #158 is one example of this.

js-beautify does not support xml beautification at this time. beautifier/js-beautify#648 is the feature request for beautifying xml. That said we will attempt to fix xml related bugs as opportunity arises.
@Glavin001 Glavin001 self-assigned this Feb 2, 2015
@prettydiff
Copy link
Collaborator

@Glavin001 you could use Pretty Diff for XML beautification. The markup parser in Pretty Diff was written to support XML first and then HTML support was added with an option on top of the XML parser. This is mostly seamless if using Pretty Diff's language auto-detection.

@Glavin001
Copy link
Owner

Definitely want to use PrettyDiff. Thanks for heads up!

@Glavin001
Copy link
Owner

@prettydiff will handle XML in the next release (see #282).

@Glavin001 Glavin001 modified the milestone: v1.1.0 May 1, 2015
Glavin001 referenced this issue May 3, 2015
@Glavin001
See #282. Improve Beautifier options definition handling
9211a03 
What's new:
- Beautifier options definition supports:
    - boolean - enable/disable
    - string - rename and enable
    - function - transform and enable
    - array - apply complex transformation to multiple options and
      output single option result
- Show "Supported by <beautifiers>" for each language option
    - Beautifiers have a name
    - Beautifier options definition is used to determine if
    language option is supported by a beautifier
- Remove SQL test, since sqlformat is inconsistant
@Glavin001 Glavin001 mentioned this issue May 3, 2015
Closed
@Glavin001 Glavin001 modified the milestones: v0.25.0, v0.26.0 May 3, 2015
@Glavin001
Copy link
Owner

Published to v0.25.0

This is a very big release with lots of internal changes and (hopefully) no breaking changes. Please let me know if you are experiencing any unusual behaviour / breaking changes after updating. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Glavin001 Glavin001

Labels
add-language feature
Projects
None yet
Milestone
v0.25.0
Development

No branches or pull requests
3 participants
@prettydiff @Glavin001 @bitwiseman