Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcription error marking up equation for leading factor. #5

Closed
philderbeast opened this issue Nov 21, 2017 · 1 comment
Closed

Comments

@philderbeast
Copy link
Contributor

The equation shown for leading factor in the docs I marked up as

https://github.com/BlockScope/CIVL-GAP/blob/e26334b23531dd8b314d1c32c5304fc4aef2121a/gap.tex#L1264

I perhaps transcribed from the current docs incorrectly because there the equation looks like

((LCp - LCmin)/sqrt(LCmin))^(2/3)

I now think that the equation should be

((LCp - LCmin)^2/sqrt(LCmin))^(1/3)

This matches the functions I use for plotting leading points, here for a LCmin value of 1.25

https://github.com/BlockScope/CIVL-GAP/blob/e26334b23531dd8b314d1c32c5304fc4aef2121a/leading-points.tex#L15

@joergewald
Copy link

Gap.cs, lines 834ff:
double lc_diff = Math.Round(lc - smallest_leading_coefficient, 5, MidpointRounding.AwayFromZero);
double slc5 = Math.Pow(smallest_leading_coefficient, 0.5);
double tmp = lc_diff / slc5;
leading_points = 1 - Math.Pow(tmp, 0.666);
if (leading_points < 0) leading_points = 0;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants