Crash on startup Forge 31.1.95+

[pupnewfster]

Bug Report

How can the crash be reproduced?

Start Biomes O' Plenty with forge 31.1.95. The issue has to do with this commit or more specifically this line. SoundEvents are not registered before items so it tries to call .delegate on the null SoundEvent that Biomes O' Plenty is passing to it. I recommend using the new constructor that takes a supplier so can properly work.

Crash Report and Logs

Latest.log: https://gist.github.com/pupnewfster/597ea6f522613c8796506f7eb4a3ec50 (with a couple extra mods from me testing something but does not have anything to do with this crash). I am also not including the crash report as an invalid one is produced due to MinecraftForge/MinecraftForge#6374

Mod Version

10.0.0.360
Forge: 31.2.0

[Shockks]

yes indeed, confirming this crash in my live server test also.

[sincalloway]

I am having this same issue, Does anyone know how to fix it?

[TheHelperBot]

So First Off What Version are you playing?
Second Did You Download The Latest Version Of Biomes o plenty? Depends on Version you are playing?

[jrkulmer]

Can also confirm the bug. Repro confirmed: Forge 31.1.95+ inclusive & BOP 10.0.0.360

[Shockks]

I am having this same issue, Does anyone know how to fix it?

ive rolled back to forge 31.1.93 and its working fine

[TheHelperBot]

the crash report log that you send on your main comment is the biomesoplenty was not load_registries from this issue there are few ways to fix this

1. use other forge version aka downgrade your forge at least 31.1.90 or lower
2. try using old version of biomes o plenty
3. use the release version of biomes o plenty beta versions might be not stable due to fact that they are working to fix the issue

if one of this 3 aren't working for you try waiting for the dev to update them

[pupnewfster]

the crash report log that you send on your main comment is the biomesoplenty was not load_registries from this issue there are few ways to fix this

1. use other forge version aka downgrade your forge at least 31.1.90 or lower
2. try using old version of biomes o plenty
3. use the release version of biomes o plenty beta versions might be not stable due to fact that they are working to fix the issue

if one of this 3 aren't working for you try waiting for the dev to update them

First of all referencing the log I gave as if I am one of the people asking for the fix instead of just being willing to wait for the fix is silly as I also clearly pointed out which line/what the issue is. The only place I use Biomes O' Plenty is in Mekanism's Data generators for the compat recipes we add. If I really wanted to get it working right now instead of not minding if it takes a few days I would spend the 5-10 minutes to clone the repo fix the bug and submit a PR request building and playing with it while I wait. I mainly made this issue to inform the devs that the crash exists rather than them not necessarily knowing until they try to update forge. Secondly unless the release build does not contain the music discs that BOP adds it will also crash.

[delilahhf]

I'm a total noob and have no idea how to code or what to do.

Would you guys suggest just waiting for an update to get BoP to work?

[jcardii]

Crashes also with BoP 345 (BoP release for 1.15) and Forge 1.15.2 - 31.2.0 (now the recommended Forge release). As reported above, does not crash on Forge 31.1.93 and BoP 345.

[AtlaStar]

There is a fix here (worked on my machine locally in a singleplayer environment at least), but it only works with Forge 31.2.0 as it uses methods that were added in the patch referenced by the OP. If someone with privileges makes a 31.2.0 and above branch I can submit the PR.

https://github.com/AtlaStar/BiomesOPlenty/tree/Forge-31.2.0-Fixes

EDIT: I suppose it works with Forge 31.1.95 considering that was the version where the change to the MusicDiscItem was made.