Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark theme #11

Closed
mariobrostech opened this issue Sep 3, 2021 · 6 comments · Fixed by #14
Closed

Add dark theme #11

mariobrostech opened this issue Sep 3, 2021 · 6 comments · Fixed by #14
Labels
enhancement New feature or request

Comments

@mariobrostech
Copy link

Hi, I just wanted to start off by thanking you for making such a useful app that I use almost daily! Really incredible work :)

As functional and pretty as the app's UI is, though, the interface can be quite bright when used at night, and devices with AMOLED screens would greatly benefit from having a black/AMOLED theme available to switch to. I know this would be a big undertaking, but do you have any interest in implementing additional themes in Githo? I know this will probably take a while to fully implement, so I just wanted to hear your thoughts on implementing such a feature and how feasable you think it might be.

Thanks in advance!

@Glitchy-Tozier Glitchy-Tozier added the enhancement New feature or request label Sep 5, 2021
@Glitchy-Tozier
Copy link
Owner

Great to hear that you enjoy the app! :)

I knew this request would come, eventually! And I'm not opposed it. I'm not going to add theme-customization (mainly because it's an insane amount of work), but I like the idea of having a dark theme.

I will work at it, but I can't tell you whether I'll be able to implement it within the next week or within the next 3 weeks, mainly because currently there's a lot going on for me. I'll let you know when I have implemented the dark theme, though. :)

@Glitchy-Tozier Glitchy-Tozier changed the title Add additional theming options Add dark theme Sep 5, 2021
@mariobrostech
Copy link
Author

Awesome, thanks for your reply! Take your time as well; I get that doing an entirely new theme is a huge undertaking, so take all of the time you need to get that right :)

I'm not going to add theme-customization

I'm not quite sure what you mean by this part, though. Does this mean you're only implementing a dark theme and not a purely black theme for devices with AMOLED displays? It would be unfortunate if that were the case. Many devices would benefit from having such a theme available. I'm not asking for a fully-fledged theming engine, though, so maybe you misread my original feature request? Either way, I'm sure it'll end up looking great!

Regardless, thanks for taking my request into consideration, and I wish you the best in implementing it!

@Glitchy-Tozier
Copy link
Owner

Does this mean you're only implementing a dark theme and not a purely black theme for devices with AMOLED displays?

I never even thought an AMOLED theme. Do you know of any good resources that explain what the difference is between AMOLED and dark theme?

I'm not quite sure what you mean by this part, though.

I meant i wasn't going to implement full theme customization, where the user can choose every color himself.

@mariobrostech
Copy link
Author

I don't know of any good resources explaining the difference between dark/AMOLED themes, but I'll do my best to summarize what I've observed through my experience.

Typically, a dark theme uses some tint of gray/blue for the background color, while an AMOLED theme would use a purely black background. This is because AMOLED displays can completely shut off pixels that aren't being lit (aka, displaying a purely black background), resulting in marginal power savings for devices with these types of displays. AMOLED themes can also sometimes have less contrast and lack things like item/margin borders in some cases, but this drastically varies between different apps and is up to the designer's discretion.

An app that does a pretty good job demonstrating this difference is Wikipedia, which you can download from Google Play or F-Droid. Once downloaded, open the app and go to More > Settings > App theme, and you'll see options to switch between light, dark, and black/AMOLED themes at the bottom of your screen. I've attached screenshots so you can see what these options look like without downloading the app.

Also, one last thing: not all apps have a dedicated black/AMOLED theme. Some omit it entirely, while others just make the standard dark theme into a black/AMOLED theme. There's a lot of calls you'll need to make as the designer, and there's no "right" or wrong" way to do this. As an end-user, I prefer apps that give the user the choice between all 3 (light, dark, and black) themes, but you don't have to do this by any means.

I hope that helps, and feel free to reach out with any other questions!

Wikipedia's Light Theme:
Screenshot_20210906-120326_Wikipedia

Wikipedia's Dark Theme:
Screenshot_20210906-120332_Wikipedia

Wikipedia's Black Theme:
Screenshot_20210906-120337_Wikipedia

@Glitchy-Tozier
Copy link
Owner

Still working on this. If you ever plan to create an app that's supposed to have complex theming, don't use Flutter!

@Glitchy-Tozier
Copy link
Owner

Glitchy-Tozier commented Oct 27, 2021

Themes should finally be done. Fixing other issues may still take a few weeks, but in the mean-time, here's a preview:

I think dark turned out particularly well :)

Dark:
Screenshot_20211027-152254.jpg

Black:
Screenshot_20211027-152305.jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants