Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications not working as expected #21

Closed
EmiliaBlasten opened this issue Apr 13, 2022 · 6 comments
Closed

Notifications not working as expected #21

EmiliaBlasten opened this issue Apr 13, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@EmiliaBlasten
Copy link

The notification just buzzes my phone and does not leave any visible message in the notification tab. If I miss the buzz there is no way for me to see that I was supposed to do something unless I explicitly open the app.

I have notifications enabled:
Screenshot_20220413-112128
Screenshot_20220413-112142

The Android notifications tab does not display anything related to the app:
Screenshot_20220413-112313

I am running version 1.3.2 from F-Droid.

edit: the "rotating arrow" notification icon in the first two screenshots is from another app.

Originally posted by @EmiliaBlasten in #17 (comment)

@Glitchy-Tozier
Copy link
Owner

Interesting, thank you for your bug-report!
I was having an issue where notifications wouldn't show up at all; most of the time my phone has its sounds&vibrations disabled though, so it might actually be facing the same bug.

A few questions:

  1. Is the notification always on time?
  2. Did the notification-time ever reset to 00:00, 02:00 or 23:59 without you doing anything?
  3. Have the notifications ever showed up in any scenario or has it always been buzz-only?
  4. If you stare at your phone at 11:20, can you see the notification appearing and then dissappearing immediately or does it never even show up at all?

@EmiliaBlasten
Copy link
Author

Thanks for the quick reply! I have not had the app for long yet, so take my answers with a grain of salt:

1. Is the notification always on time?

It has been on time: I set it to 11:20 at 09:00 this morning and it buzzed at the right time. I also tried setting it a few times for a couple of minutes later (e.g. at 11:35 I would set it to 11:37 for testing) and in each case the phone buzzed at the right time.

2. Did the notification-time ever reset to 00:00, 02:00 or 23:59 without you doing anything?

The notification time has never changed by itself in the total 20 hours of having it installed.

3. Have the notifications ever showed up in any scenario or has it always been buzz-only?

So far it has been a buzz only. However I have used the app for less than 24 hours. I am wondering if the weird hours selector might cause the notification to display every other day, but I need to have longer usage before making any guesses.

Weird in-app hours selector:
Screenshot_20220413-201652
Compared to the usual Android hour selector:
Screenshot_20220413-201937

4. If you stare at your phone at 11:20, can you see the notification appearing and then dissappearing immediately or does it never even show up at all?

I don't see a notification appearing even for a split second. So it's only the buzz as far as I can tell.

@Glitchy-Tozier
Copy link
Owner

Glitchy-Tozier commented Apr 14, 2022

I am wondering if the weird hours selector might cause the notification to display every other day, but I need to have longer usage before making any guesses.

  1. I agree that it's kind of weird, but it's an official widget, coming directly from Google.
    The design is pretty new. In case you're imterested, here's a small article about it: https://www.androidheadlines.com/2021/08/material-you-design-android-time-picker.html
  2. The time-picker works flawlessly, something else is broken, unfortunately.

Everything else

Thank you for providing the information!
The weird thing is, it's difficult to test this bug consistently.

  • On your device, there's only buzzing and nothing else
  • On my device, there's nothing at all, not even a buzz
  • When using my test setup, notifications show up, but sometimes seem appear at the wrong time.

I'll investigate further into this, but it might take me a few days.

@Glitchy-Tozier Glitchy-Tozier added the bug Something isn't working label Apr 21, 2022
@Glitchy-Tozier
Copy link
Owner

Glitchy-Tozier commented Apr 21, 2022

(I think) I managed to fix this issue in this commit. The problem was that the notification's icon was removed by the compiler, which caused notifications to break/fail. See here for more details.

I'll release the next version of Githo today or tomorrow, meaning that the update should show up within 3-5 days on F-droid.

Thank you again for reporting this bug!

@EmiliaBlasten
Copy link
Author

F-droid got version 1.3.3 today and the notification did indeed work. Cheers!

@Glitchy-Tozier
Copy link
Owner

Thank you for confirming that it now works!

Should you notice any other irregularities regarding notifications, make sure to let me know! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants