Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashtag, Emoji and Mention Handler not Working #273

Open
ertugrul-dmr opened this issue May 21, 2021 · 1 comment
Open

Hashtag, Emoji and Mention Handler not Working #273

ertugrul-dmr opened this issue May 21, 2021 · 1 comment
Assignees

Comments

@ertugrul-dmr
Copy link
Collaborator

ertugrul-dmr commented May 21, 2021

While working on some preprocessing steps (#270) we noticed that arguments for tokenizers (including Text2Doc) has no effect on the outcome. Basically enable/disable options are not working.

For this issue we might need to create test cases and find the root cause of the problem.

To replicate this you can basically follow these steps:

from sadedegel.bblock.word_tokenizer import ICUTokenizer
tokenizer = ICUTokenizer(hashtag=True, mention=True, emoji=True)
text = 'bu #bir @metindir, 🍰'
print(tokenizer._tokenize(text))

Will result same with False or True options. Same goes for Text2Doc example below:

from sadedegel.extension.sklearn import Text2Doc
tokenizer = Text2Doc(hashtag=True, mention=True, emoji=True)
texts =[ 'bu', '#bir', '@metindir', '🍰']
print(tokenizer.transform(texts))
@ertugrul-dmr ertugrul-dmr changed the title Hashtag Hashtag, Emoji and Mention Handler not Working May 21, 2021
@ertugrul-dmr ertugrul-dmr added the bug Something isn't working label May 21, 2021
@ertugrul-dmr ertugrul-dmr reopened this May 21, 2021
@husnusensoy
Copy link
Contributor

Please refer to pr #274 to see that this is not a bug but the expected behavior

@husnusensoy husnusensoy removed the bug Something isn't working label May 26, 2021
@husnusensoy husnusensoy reopened this May 28, 2021
@ertugrul-dmr ertugrul-dmr linked a pull request Jul 13, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants