Skip to content
This repository has been archived by the owner on Jun 17, 2023. It is now read-only.

Documentation for canonicalName #480

Closed
JRice opened this issue Jan 28, 2019 · 2 comments
Closed

Documentation for canonicalName #480

JRice opened this issue Jan 28, 2019 · 2 comments

Comments

@JRice
Copy link

JRice commented Jan 28, 2019

https://github.com/GlobalNamesArchitecture/gnparser/blob/master/README.rst#getting-the-simplest-possible-canonical-form

...This references names that I am not seeing in the JSON response. Perhaps this is covered in #209 but I thought it would be lower-hanging fruit to just update those strings in the existing docs.

@JRice JRice changed the title Documentation for canonicalForm Documentation for canonicalName Jan 28, 2019
@dimus
Copy link
Member

dimus commented Feb 2, 2019

@JRice you probably did not see these names because in Go version of gnparser (they are called CanonicalName->simple and CanonicalName->full in contrast with Scala parser. The reason for chaning was omitting hybrid signs in simple for named hybrids. Many times people omit hybrid sign for named hybrids, and we do want to match Iris germanica and Iris x germanica using simple canonical form. So simple form is for matching purposes, and full form is for presentation purposes.
We changed the name because valueRanked now includes named hybrids, and its semantic meaning drifted as a result. I added an issue for Go parser https://gitlab.com/gogna/gnparser/issues/44

@dimus
Copy link
Member

dimus commented Feb 2, 2019

Closing it here, as the ticket is related to https://gitlab.com/gogna/gnparser

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants