Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Do list: list structure #1

Merged
merged 19 commits into from Aug 11, 2022
Merged

Conversation

GloireIrenge
Copy link
Owner

馃摋 I made this To Do List web project with the following changes and functionalities:

  • This project is set up using the webpack plugin.
  • I created an index.html file with an empty To Do List placeholder.
  • The index.html file is set as a template using the HTML Webpack Plugin.
  • I created an index.js file and set an array of some simple to-do tasks (with three keys: description [string]. completed [bool]. index: [number].
  • I Wrote a showTodo function to iterate over the tasks array and populate an HTML list item element for each task.
  • The to-do list is rendered dynamically when the page is loaded.

Copy link

@HAMMAS-SALEEM HAMMAS-SALEEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required Changes 鈾伙笍

almost-there

Hey @GloireIrenge 馃憢

Highlights 馃

鉁旓笍 Following Linters
鉁旓笍 Descriptive PR Summary
鉁旓笍 Descriptive PR Title

Good job on implementing some of the requirements, there are some issues that you still need to work on to go to the next project but you are almost there! 馃槉

Optional Suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding 馃憦 馃憦 馃憦

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @HAMMAS-SALEEM in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

* Released under MIT license <https://lodash.com/license>
* Based on Underscore.js 1.8.3 <http://underscorejs.org/LICENSE>
* Copyright Jeremy Ashkenas, DocumentCloud and Investigative Reporters & Editors
*/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your MIT.md 馃摑

MIT md

  • Your MIT.md file is empty. Means you didn't add your name, current year, and app-type. Please add these things 馃憤 This is the license file of your project so please take it seriously. 馃

Copy link

@AmaduKamara AmaduKamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved 馃煝馃煝馃煝

Hi @GloireIrenge,

Good job working on the change the previous reviewer asked 馃憤

Your project is complete! There is nothing else to say other than... it's time to merge it: ship it:
Congratulations! 馃帀

Highlights:

鉁旓笍 You used Gitflow correctly
鉁旓笍 No linter error
鉁旓笍 README is professional

Cheers and Happy coding!馃憦馃憦馃憦

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@GloireIrenge GloireIrenge merged commit 99d9c44 into master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants