Add and remove items from To Do List #2
Conversation
There was a problem hiding this comment.
STATUS: REQUIRED CHANGES ♻️
Hi @GloireIrenge 👋,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights 🎯
✔️ Correct GitHub Flow
✔️ Descriptive PR
✔️ No linter errors
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/Add_remove.js
Outdated
| addTodo = (task, todos) => { | ||
| todos.push(task); | ||
| localStorage.setItem('todos', JSON.stringify(todos)); | ||
| } | ||
|
|
There was a problem hiding this comment.
- At the moment, when a to-do task is saved to localStorage, the
indexproperty is always set to0. This is not the expected behaviour. Theindexproperty for each to-do item should be set to the value of the new array length. Please implement this requirement 🙏
Kindly see the bug below 👇
src/Add_remove.js
Outdated
| deleteTodo = (e, todos) => { | ||
| e.target.parentElement.remove(); | ||
| todos.splice(e.target.parentElement.id, 1); | ||
| localStorage.setItem('todos', JSON.stringify(todos)); | ||
| } | ||
| } |
There was a problem hiding this comment.
- When a to-do list item is deleted, please remember to update all remaining items' indexes, so they represent the current list order and are unique 👍
There was a problem hiding this comment.
Hi @GloireIrenge, 👋
Highlights 👏
- Nice job doing the suggested changes, great! 😎
- Great work using the right GitHub Flow.
- Your README looks professional, well done!
- Commits are descriptive, good work.
- Linters are working properly, great job!
Your project is complete! There is nothing else to say other than... it's time to merge it! 🚀
Very nice work, congratulations! 🎉
APPROVED! 💯 💯 💯
Cheers and Happy coding! 🤓
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
✅ Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
This part of the project is made with the following changes and functionalities :