Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2p code review 8/16/22 #8

Open
melashu opened this issue Aug 16, 2022 · 0 comments
Open

P2p code review 8/16/22 #8

melashu opened this issue Aug 16, 2022 · 0 comments

Comments

@melashu
Copy link

melashu commented Aug 16, 2022

Feedback from Aamir Khan

Hi @GloireIrenge, your project is looking beautiful so far. However, there are issues that you need to go through.

  • The deployment is not looking correct it is beacuse CSS and JS are not loading well, please kindly fix it.
  • Please create different modules not write all codes in one module.
  • As much as you can it is better to follow the javascript best practice , for example, it is better to use a local variable instead of the global variable.

Feedback from Meshu Amare

  • From src/index.js on line number 60,110 you declare a variable. I think it is better to put it at the top of the script.
  • When you declare a variable if the variable has two words like DeleteSelected it is better to use camel case notiation like deleteSelected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant