-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate download func to smaller units #19
Comments
Cool! |
Partially addressed by #29. |
Now with #29 merged, we can think about whether and how to split the |
Streams would help this a lot. See #70. |
Partially addressed by #72. I am not sure yet how to split out the body extraction from the response object. |
#72 eventually resolved this completely. |
We'd like to divide Onigumo.download to smaller parts with philosophy one func make one task.
This approach is more suitable for deep testing also. We'd like to use tmp_dir in test for testing files, for this intention we need to have the way how to give filepath as argument. When we reach it, we will be able to give tmp_dir as argument to make integration tests.
Onigumo.download make three different tasks at this moment.
Three tasks are:
The text was updated successfully, but these errors were encountered: