Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(admin-ui): admin-ui will call licenseSpring apis via. SCAN #896

Closed
duttarnab opened this issue Mar 31, 2023 · 1 comment
Closed

feat(admin-ui): admin-ui will call licenseSpring apis via. SCAN #896

duttarnab opened this issue Mar 31, 2023 · 1 comment
Assignees
@duttarnab
Labels
comp-admin-ui Component affected by issue or PR enhancement New feature or request kind-feature Issue or PR is a new feature request

Comments

@duttarnab
Copy link
Contributor

duttarnab commented Mar 31, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
As per the current design the /license API in SCAN is visible to users (in ADS). So the licenseSpring credentials can be easily exposed to the client.

Describe the solution you'd like
We will remove /license API in SCAN to fetch licenseSpring credentials (api-key, shared-key and productCode). Admin UI will access springLicense APIs via. SCAN. (openapi specs attached).
SCAN_license.txt
@duttarnab duttarnab added enhancement New feature or request comp-admin-ui Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Mar 31, 2023
@duttarnab duttarnab self-assigned this Mar 31, 2023
@duttarnab duttarnab mentioned this issue Apr 5, 2023
Closed
3 tasks
@duttarnab
Copy link
Contributor Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duttarnab duttarnab

Labels
comp-admin-ui Component affected by issue or PR enhancement New feature or request kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@duttarnab