Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate from butterknife to Jetpack view bindings #73

Open
27 tasks
hades opened this issue Apr 4, 2024 · 2 comments · May be fixed by #115
Open
27 tasks

migrate from butterknife to Jetpack view bindings #73

hades opened this issue Apr 4, 2024 · 2 comments · May be fixed by #115

Comments

@hades
Copy link

hades commented Apr 4, 2024

The code currently uses Butterknife[1] which is deprecated in favour of view bindings[2].

There are 27 files that use view binding:

  • app/src/main/java/org/gnucash/android/ui/account/AccountFormFragment.java
  • app/src/main/java/org/gnucash/android/ui/account/AccountsActivity.java
  • app/src/main/java/org/gnucash/android/ui/account/AccountsListFragment.java
  • app/src/main/java/org/gnucash/android/ui/budget/BudgetAmountEditorFragment.java
  • app/src/main/java/org/gnucash/android/ui/budget/BudgetDetailFragment.java
  • app/src/main/java/org/gnucash/android/ui/budget/BudgetFormFragment.java
  • app/src/main/java/org/gnucash/android/ui/budget/BudgetListFragment.java
  • app/src/main/java/org/gnucash/android/ui/common/BaseDrawerActivity.java
  • app/src/main/java/org/gnucash/android/ui/export/ExportFormFragment.java
  • app/src/main/java/org/gnucash/android/ui/homescreen/WidgetConfigurationActivity.java
  • app/src/main/java/org/gnucash/android/ui/report/BaseReportFragment.java
  • app/src/main/java/org/gnucash/android/ui/report/ReportsActivity.java
  • app/src/main/java/org/gnucash/android/ui/report/ReportsOverviewFragment.java
  • app/src/main/java/org/gnucash/android/ui/report/barchart/StackedBarChartFragment.java
  • app/src/main/java/org/gnucash/android/ui/report/linechart/CashFlowLineChartFragment.java
  • app/src/main/java/org/gnucash/android/ui/report/piechart/PieChartFragment.java
  • app/src/main/java/org/gnucash/android/ui/report/sheet/BalanceSheetFragment.java
  • app/src/main/java/org/gnucash/android/ui/settings/PreferenceActivity.java
  • app/src/main/java/org/gnucash/android/ui/transaction/SplitEditorFragment.java
  • app/src/main/java/org/gnucash/android/ui/transaction/TransactionDetailActivity.java
  • app/src/main/java/org/gnucash/android/ui/transaction/TransactionFormFragment.java
  • app/src/main/java/org/gnucash/android/ui/transaction/TransactionsActivity.java
  • app/src/main/java/org/gnucash/android/ui/transaction/TransactionsListFragment.java
  • app/src/main/java/org/gnucash/android/ui/transaction/dialog/TransferFundsDialogFragment.java
  • app/src/main/java/org/gnucash/android/ui/util/dialog/DateRangePickerDialogFragment.java
  • app/src/main/java/org/gnucash/android/ui/wizard/CurrencySelectFragment.java
  • app/src/main/java/org/gnucash/android/ui/wizard/FirstRunWizardActivity.java

[1] https://github.com/JakeWharton/butterknife
[2] https://developer.android.com/topic/libraries/view-binding#kts
@hades
Copy link
Author

hades commented Apr 4, 2024

If no one has any objections, I can work on migrating these classes.

@djbrown
Copy link

djbrown commented Apr 4, 2024

Seems reasonable, according to the readme it's deprecated.
Not sure about how big of an impact that will have and conflict potential with pending/incoming changes from @pnemonic78.
But please feel free to work in it 👍🏾

@hades hades linked a pull request May 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate from Butterknife to View bindings hades/gnucash-android
2 participants
@hades @djbrown