Skip to content

Commit

Permalink
Fix 2 "[WARN] FOUserAgent - Destination: Unresolved ID reference"
Browse files Browse the repository at this point in the history
messages when building help pdf. The problem is when linking to an id
defined in a title tag.
1. destination "trans-match-col" in Help_ch_Transactions.xml:
  Html: clicking the link incorrectly takes you to the start of the
  enclosing sect1 tag
  Pdf: link not created
2. destination "report-common.title" in Help_ch_Reports.xml:
  Html: link works
  Pdf: link not created
The fix is to move the id's from the title tag to the previous sectx
tag. This was simple in Help_ch_Reports.xml as there was already an
enclosing sectx tag but in Help_ch_Transactions.xml new sect's had to be
created and this involved much indenting. No content is changed in this
commit.
After the fix, the links work correctly in both html + pdf.
  • Loading branch information
goodvibes2 authored and jralls committed Mar 27, 2022
1 parent 3597123 commit 5251a91
Show file tree
Hide file tree
Showing 2 changed files with 458 additions and 439 deletions.
22 changes: 11 additions & 11 deletions manual/C/Help_ch_Reports.xml
Expand Up @@ -221,7 +221,7 @@
</sect2>

<sect2 id="report-common">
<title id="report-common.title">Common Report Options</title>
<title>Common Report Options</title>

<para>Many reports share similar options. Some common ones include:
</para>
Expand Down Expand Up @@ -2192,7 +2192,7 @@ Income (type INCOME)
<title>Report Options</title>

<note>
<para>See <link linkend='report-common' endterm="report-common.title"/> in the <emphasis>Configuring
<para>See <xref linkend="report-common"/> in the <emphasis>Configuring
Reports and Charts</emphasis> section of this help manual for more details of the
common options.
</para>
Expand All @@ -2206,26 +2206,26 @@ Income (type INCOME)
<itemizedlist>
<listitem>
<para><guilabel>Report name</guilabel>: Enter a descriptive name for this report - see
<link linkend='report-common' endterm="report-common.title"/>.
<xref linkend="report-common"/>.
</para>
</listitem>

<listitem>
<para><guilabel>Stylesheet</guilabel>: Select a style sheet for this report - see
<link linkend='report-common' endterm="report-common.title"/>.
<xref linkend="report-common"/>.
</para>
</listitem>

<listitem>
<para><guilabel>To</guilabel>: Select a date to report on or a named date. Transactions up to and
including the selected date will be used to calculate the outstanding aged
balances. See <link linkend='report-common' endterm="report-common.title"/>.
balances. See <xref linkend="report-common"/>.
</para>
</listitem>

<listitem>
<para><guilabel>Report's currency</guilabel>: Select the currency to display the values in - see
<link linkend='report-common' endterm="report-common.title"/>
<xref linkend="report-common"/>
</para>
</listitem>

Expand Down Expand Up @@ -2487,7 +2487,7 @@ Income (type INCOME)
<title>Report Options</title>

<note>
<para>See <link linkend='report-common' endterm="report-common.title"/> in the <emphasis>Configuring
<para>See <xref linkend="report-common"/> in the <emphasis>Configuring
Reports and Charts</emphasis> section of this help manual for more details of the
common options.
</para>
Expand All @@ -2501,26 +2501,26 @@ Income (type INCOME)
<itemizedlist>
<listitem>
<para><guilabel>Report name</guilabel>: Enter a descriptive name for this report - see
<link linkend='report-common' endterm="report-common.title"/>.
<xref linkend="report-common"/>.
</para>
</listitem>

<listitem>
<para><guilabel>Stylesheet</guilabel>: Select a style sheet for this report - see
<link linkend='report-common' endterm="report-common.title"/>.
<xref linkend="report-common"/>.
</para>
</listitem>

<listitem>
<para><guilabel>To</guilabel>: Select a date to report on or a named date. Transactions up to and
including the selected date will be used to calculate the outstanding aged
balances. See <link linkend='report-common' endterm="report-common.title"/>.
balances. See <xref linkend="report-common"/>.
</para>
</listitem>

<listitem>
<para><guilabel>Report's currency</guilabel>: Select the currency to display the values in - see
<link linkend='report-common' endterm="report-common.title"/>.
<xref linkend="report-common"/>.
</para>
</listitem>

Expand Down

0 comments on commit 5251a91

Please sign in to comment.