Skip to content

Commit

Permalink
Update gwen/aqbanking to latest version, as needed for server changes…
Browse files Browse the repository at this point in the history 
… in Germany's banks.
  • Loading branch information
@cstim
cstim committed Aug 9, 2019
1 parent 0178c94 commit e9754cc
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions gnucash.modules
View file
Expand Up @@ -18,7 +18,7 @@
<repository type="git" name="aquamaniac"
href="https://git.aquamaniac.de/git/"/>
<repository type="tarball" name="aqbanking"
href="https://www.aquamaniac.de/sites/download/"/>
href="https://www.aquamaniac.de/rdm/attachments/download/"/>
<repository type="git" name="github"
href="git://github.com/"/>
<repository type="tarball" name="github-tar"
Expand Down Expand Up @@ -146,7 +146,7 @@

<autotools id="gwenhywfar" autogen-sh="configure"
autogenargs="--with-guis='gtk3' --enable-local-install --disable-binreloc --disable-ssl">
<branch module="download.php?package=01&amp;release=208&amp;file=02&amp;dummy=gwenhywfar-4.20.0.tar.gz" version="4.20.0" repo="aqbanking" checkoutdir="gwenhywfar-4.20.0">
<branch module="104/gwenhywfar-4.20.1.tar.gz" version="4.20.1" repo="aqbanking" checkoutdir="gwenhywfar-4.20.1">
</branch>
<dependencies>
<dep package="gcrypt"/>
Expand Down Expand Up @@ -174,8 +174,7 @@

<autotools id="aqbanking" autogen-sh="autoreconf" makeargs="-j1"
autogenargs="--enable-local-install">
<branch module="download.php?package=03&amp;release=217&amp;file=02&amp;dummy=aqbanking-5.7.8.tar.gz" repo="aqbanking" version="5.7.8" checkoutdir="aqbanking-5.7.8">
<patch file="Fix-signature-mismatch-in-abgui.c.patch" strip='1'/>
<branch module="103/aqbanking-5.8.0beta.tar.gz" repo="aqbanking" version="5.8.0" checkoutdir="aqbanking-5.8.0">

This comment has been minimized.

Sign in to view

Copy link
@jralls

jralls Aug 9, 2019

Member

Cstim: We should not inflict beta code on users in a stable release. Please revert this ASAP.

This comment has been minimized.

Sign in to view

Copy link
@fellen

fellen Aug 9, 2019 •
edited

Member

New Bank reglulations require the use in september.
Current state: https://lists.gnucash.org/pipermail/gnucash-de/2019-August/010715.html ff

This comment has been minimized.

Sign in to view

Copy link
@fellen

fellen Aug 10, 2019

Member

@cstim see also https://lists.gnucash.org/logs/2019/08/09.html

This comment has been minimized.

Sign in to view

Copy link
@jralls

jralls Aug 10, 2019

Member

@cstim then get Martin to fix his naming convention to match the rest of the world, where "beta" in a version number means that it's unstable testing.

And as I pointed out on IRC last night, 40 days is way too short a fuse to be dropping this change. It will only show up in bleeding-edge distros in time and has little chance of even making it into Ubuntu 19.10. The EU regulation was enacted 4 years ago so there was plenty of time to do this right.

And BTW, this change broke the build because Gwenhyfwar's configure couldn't find Gtk3 in pkg-config.

Please revert this change and please don't push changes that you haven't tested. If you're not able to test, make a PR and ask someone to test it for you ("someone" probably means me, last I heard @gjanssens still hadn't replaced his Windows development box).

This comment has been minimized.

Sign in to view

Copy link
@gjanssens

gjanssens Aug 10, 2019

Member

In fact I have replaced my Windows development box for some time now :)
Still doing Windows 7 so I can test for the oldest supported Windows version.
Not much time yet for gnucash development on the other hand though...

This comment has been minimized.

Sign in to view

Copy link
@jralls

jralls Aug 10, 2019

Member

So still probably me then.

This comment has been minimized.

Sign in to view

Copy link
@jralls

jralls Aug 10, 2019 •
edited

Member

@cstim, How about instead of updating AQB we patch it with that commit instead? Still won't do anything for Linux users, but maybe you could get Martin to do a 5.7.10 with just those two patches. Having it as a nano version improves the odds that distros will put it in an update instead of waiting for an OS release. That would be two years for Debian as they just dropped one last month.

This comment has been minimized.

Sign in to view

Copy link
@bhardwajs

bhardwajs Aug 10, 2019

I use the nightly build on Windows 10. If there is anything that need to be tested in Windows, please let me know and I can try to test it.

This comment has been minimized.

Sign in to view

Copy link
@cstim

cstim Aug 11, 2019

Author Member

The last nightly now built successfully. This is with aqbanking-5.8.0 from this patch, but gwenhywfar reverted to 4.20.0 even though the server URL is now different.

I will work on the aqbanking version number scheme to get the "beta" removed there, but this might take some time.

To my understanding, the issues raised above should probably be solved.
</branch>
<dependencies>
<dep package="gwenhywfar"/>
Expand Down

1 comment on commit e9754cc

@jralls
Copy link
Member

@jralls jralls commented on e9754cc Aug 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhardwajs Thanks for the offer, but this is about building on windows, not testing the nightly build. Plus, unless you use Germany's FinTS for online banking this change isn't relevant to you.

Please sign in to comment.