Merge Richard Cohen's 'show-log-window-should-show-the-window' into m…

…aster.
Gnucash · Mar 16, 2023 · 047dad2 · 047dad2
2 parents 68ece42 + 8e9c65c
commit 047dad2
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/gnucash/import-export/aqb/gnc-plugin-aqbanking.c b/gnucash/import-export/aqb/gnc-plugin-aqbanking.c
@@ -605,11 +605,14 @@ gnc_plugin_ab_cmd_view_logwindow (GSimpleAction *simple,
                                   GVariant *parameter,
                                   gpointer user_data)
 {
-    GVariant *state;
+    GVariant *state = g_action_get_state (G_ACTION(simple));
+    gboolean toggle = g_variant_get_boolean (state);
+    g_variant_unref (state);
 
-    state = g_action_get_state (G_ACTION(simple));
+    gboolean new_toggle = !toggle;
+    g_action_change_state (G_ACTION(simple), g_variant_new_boolean (new_toggle));
 
-    if (g_variant_get_boolean (state))
+    if (new_toggle)
     {
         if (!gnc_GWEN_Gui_show_dialog())
         {
@@ -621,7 +624,6 @@ gnc_plugin_ab_cmd_view_logwindow (GSimpleAction *simple,
     {
         gnc_GWEN_Gui_hide_dialog();
     }
-    g_variant_unref (state);
 }
 
 static void