Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[business-core] string-hash doesn't not guarantee unique hash
subtle bug here-- used string-hash to convert guid-string to a number which is faster to use as hash key. but string-hash does not guarantee that there are no hash collisions. it is best to use guid string instead which is guaranteed to uniquely define a split.
- Loading branch information
0b38615
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol @jralls I finally see the unintentional and incorrect double negative in this commit message.
Should be "[business-core] string-hash does not guarantee unique hash" of course.