Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bugs 632346 & 632166: Fixup transaction currency scrubbing.
Biggest problem was that almost well-formed transactions missing a currency element wouldn't import correctly because the FindCommonCurrencies function only used the old currency values, ignoring the commodity values in the splits' accounts. A new function, xaccFindCommonCurrencies(), looks at those first and then calls xaccFindOldCommonCurrencies only if it fails. That addresses the cause of the import failure reported in 632166 and a big chunk of the warning messages complained about in 632346. A secondary problem, also addressed in this change, was that the last block in xaccTransScrubCurrencyFromSplits always replaced the "amount" with the "value". This is the right thing to do if the commodity for the split account is a currency, but if it isn't, the replacement should be reversed. git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19744 57a11ea4-9604-0410-9ed3-97b8803252fd
- Loading branch information
Showing
1 changed file
with
116 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters