Skip to content

Commit

Permalink
Since-last-run dialog cleanups.
Browse files Browse the repository at this point in the history
	* gnc-sxed-window-ui.xml: Remove unreferenced `TransactionAction`.

	* dialog-sxsincelast.c (sxsld_disposition_changed): change the
	assertion into a simple return-if-fail due to apparent change in
	the calling order in gtk 2.x...



git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@12256 57a11ea4-9604-0410-9ed3-97b8803252fd
  • Loading branch information
jsled committed Jan 4, 2006
1 parent 9568565 commit 4eab2ef
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 9 deletions.
8 changes: 8 additions & 0 deletions ChangeLog
@@ -1,3 +1,11 @@
2006-01-03 Joshua Sled <jsled@asynchronous.org>

* gnc-sxed-window-ui.xml: Remove unreferenced `TransactionAction`.

* dialog-sxsincelast.c (sxsld_disposition_changed): change the
assertion into a simple return-if-fail due to apparent change in
the calling order in gtk 2.x...

2006-01-03 David Hampton <hampton@employees.org>

* src/engine/Transaction.c: When setting the amount of a split,
Expand Down
11 changes: 10 additions & 1 deletion GNOME2_STATUS
Expand Up @@ -124,6 +124,12 @@ Resources

- 2006-01-02: do these problems still exist?

- [jsled, 2006-01-03] yes...

- After opening, mousing over the existing account-tree changes all my
'$'s to 'USD'.

- I'm unable to cancel this dialog.

- Account Hierarchy Merge - BROKEN

Expand All @@ -150,7 +156,10 @@ Resources

- Scheduled Transactions

- Since Last Run dialog spews console-crap on init, generally broken?
- Since Last Run dialog should be audited for menus and ledger capabilities.

- e.g. The To-Create-Transaction read-only review ledger doesn't need any
menus or editing functionality.

- SX Editor

Expand Down
6 changes: 4 additions & 2 deletions src/gnome/dialog-sxsincelast.c
Expand Up @@ -531,7 +531,7 @@ dialog_widgets_attach_handlers(GladeXML *dialog_xml,
int i;
GtkWidget *w;

for(i = 0; handler_info[i].name != NULL; i++)
for (i = 0; handler_info[i].name != NULL; i++)
{
w = glade_xml_get_widget(dialog_xml, handler_info[i].name);
g_signal_connect( G_OBJECT(w), handler_info[i].signal,
Expand Down Expand Up @@ -3418,7 +3418,9 @@ sxsld_disposition_changed( GtkMenuShell *b, gpointer d )
glade_xml_get_widget( sxsld->gxml,
SX_DISPOSITION_OPT ));
/* Change the state of the TCI */
g_assert( sxsld->curSelTCI != NULL );
//g_assert( sxsld->curSelTCI != NULL );
g_return_if_fail(sxsld->curSelTCI != NULL);

sxsld->curSelTCI->state = newState;

newSensitivity = TRUE;
Expand Down
2 changes: 1 addition & 1 deletion src/gnome/glade/sched-xact.glade
Expand Up @@ -5997,7 +5997,7 @@ Select any which you would like to create now, and click
<widget class="GtkStatusbar" id="to_create_status">
<property name="border_width">3</property>
<property name="visible">True</property>
<property name="has_resize_grip">True</property>
<property name="has_resize_grip">False</property>
</widget>
<packing>
<property name="padding">0</property>
Expand Down
4 changes: 2 additions & 2 deletions src/gnome/ui/gnc-plugin-page-sxregister-ui.xml
@@ -1,14 +1,14 @@
<ui>
<menubar>
<menu name="Transaction" action="TransactionAction">
<!-- menu name="Transaction" action="TransactionAction">
<menuitem name="CutTransaction" action="CutTransactionAction"/>
<menuitem name="CopyTransaction" action="CopyTransactionAction"/>
<menuitem name="PasteTransaction" action="PasteTransactionAction"/>
<separator name="TransactionSep2"/>
<menuitem name="VoidTransaction" action="VoidTransactionAction"/>
<menuitem name="UnvoidTransaction" action="UnvoidTransactionAction"/>
<menuitem name="ReverseTransaction" action="ReverseTransactionAction"/>
</menu>
</menu -->

<menu name="View" action="ViewAction">
<placeholder name="ViewContentPlaceholder">
Expand Down
3 changes: 0 additions & 3 deletions src/gnome/ui/gnc-sxed-window-ui.xml
Expand Up @@ -11,9 +11,6 @@
<placeholder name="ViewPlaceholder"/>
</menu>

<menu name="Transaction" action="TransactionAction">
</menu>

<menu name="Actions" action="ActionsAction">
<placeholder name="ActionsPlaceholder"/>
</menu>
Expand Down

0 comments on commit 4eab2ef

Please sign in to comment.