Skip to content

Commit

Permalink
Populate and display the match list in the CSV Importer.
Browse files Browse the repository at this point in the history
Also fix a crash when the imported split doesn't have an online id
as is the case for all non-OFX imports.
  • Loading branch information
jralls committed Sep 13, 2020
1 parent d4fe584 commit 53619f4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions gnucash/import-export/csv-imp/assistant-csv-trans-import.cpp
Expand Up @@ -2084,6 +2084,8 @@ CsvImpTransAssist::assist_match_page_prepare ()
draft_trans->trans = nullptr;
}
}
/* Show the matcher dialog */
// gnc_gen_trans_list_show_all (gnc_csv_importer_gui);
}


Expand Down
4 changes: 4 additions & 0 deletions gnucash/import-export/import-backend.c
Expand Up @@ -1122,6 +1122,10 @@ gboolean gnc_import_exists_online_id (Transaction *trans, GHashTable* acct_id_ha
/* Look for an online_id in the first split */
source_split = xaccTransGetSplit(trans, 0);
g_assert(source_split);

// No online id, no point in continuing. We'd crash if we tried.
if (!gnc_import_get_split_online_id (source_split))
return FALSE;
// Create a hash per account of a hash of all transactions IDs. Then the test below will be fast if
// we have many transactions to import.
dest_acct = xaccSplitGetAccount (source_split);
Expand Down

0 comments on commit 53619f4

Please sign in to comment.