Skip to content

Commit

Permalink
Merge Richard Cohen's 'fix-incorrect-logging-after-fallthrough' into …
Browse files Browse the repository at this point in the history
…stable.
  • Loading branch information
jralls committed Jun 6, 2023
2 parents 0f35543 + a0fd9af commit a5ff19b
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions libgnucash/engine/kvp-frame.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -271,15 +271,9 @@ gvalue_from_kvp_value (const KvpValue *kval, GValue* val)
g_value_init (val, G_TYPE_DATE);
g_value_set_static_boxed (val, kval->get_ptr<GDate>());
break;
case KvpValue::Type::GLIST:
PWARN ("Error! Attempt to transfer KvpGList!");
[[fallthrough]];
/* No transfer of KVP frames outside of QofInstance-derived classes! */
case KvpValue::Type::FRAME:
PWARN ("Error! Attempt to transfer KvpFrame!");
[[fallthrough]];
default:
PWARN ("Error! Invalid KVP Transfer Request!");
/* No transfer outside of QofInstance-derived classes! */
PWARN ("Error! Invalid attempt to transfer Kvp type %d", kval->get_type());
g_slice_free (GValue, val);
val = NULL;
break;
Expand Down

0 comments on commit a5ff19b

Please sign in to comment.