Remove the unused backend-configuration member and virtual setter/get…

…ters. Not used, and if it was it would be an inappropriate use of KVP.
Gnucash · Jul 4, 2015 · c721bf9 · c721bf9
1 parent 3956ee0
commit c721bf9
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 14 deletions.
diff --git a/src/backend/dbi/gnc-backend-dbi.c b/src/backend/dbi/gnc-backend-dbi.c
@@ -1763,8 +1763,6 @@ init_sql_backend( GncDbiBackend* dbi_be )
      * configured for multiuser access. */
     be->sync = gnc_dbi_safe_sync_all;
     be->safe_sync = gnc_dbi_safe_sync_all;
-    be->load_config = NULL;
-    be->get_config = NULL;
 
     be->compile_query = gnc_sql_compile_query;
     be->run_query = gnc_sql_run_query;

diff --git a/src/backend/sql/test/utest-gnc-backend-sql.c b/src/backend/sql/test/utest-gnc-backend-sql.c
@@ -583,7 +583,7 @@ test_gnc_sql_convert_timespec_to_string ()
     GncSqlBackend be = {{
             NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
             NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
-            0, NULL, 0, "", NULL, 0, "", NULL, NULL
+            0, NULL, 0, "", NULL
         },
         NULL, NULL, FALSE, FALSE, FALSE, 0, 0, NULL,
         "%4d-%02d-%02d %02d:%02d:%02d"

diff --git a/src/backend/xml/gnc-backend-xml.c b/src/backend/xml/gnc-backend-xml.c
@@ -1251,8 +1251,6 @@ gnc_backend_new(void)
     be->process_events = NULL;
 
     be->sync = xml_sync_all;
-    be->load_config = NULL;
-    be->get_config = NULL;
 
     be->export_fn = gnc_xml_be_write_accounts_to_file;
 

diff --git a/src/import-export/aqb/test/test-aqb.c b/src/import-export/aqb/test/test-aqb.c
@@ -40,7 +40,7 @@ main (int   argc,
     qof_init(); 			/* Initialize the GObject system */
     qof_log_init_filename_special("stderr"); /* Init the log system */
     g_test_init ( &argc, &argv, NULL ); 	/* initialize test program */
-    qof_log_set_level("gnc", G_LOG_LEVEL_DEBUG);
+    qof_log_set_level("gnc", (QofLogLevel)G_LOG_LEVEL_DEBUG);
     g_test_bug_base("https://bugzilla.gnome.org/show_bug.cgi?id="); /* init the bugzilla URL */
     /* Disable the transaction log */
     xaccLogDisable();

diff --git a/src/libqof/qof/qofbackend-p.h b/src/libqof/qof/qofbackend-p.h
@@ -304,9 +304,6 @@ struct QofBackend_s
 
     void (*sync) (QofBackend *, /*@ dependent @*/ QofBook *);
     void (*safe_sync) (QofBackend *, /*@ dependent @*/ QofBook *);
-    void (*load_config) (QofBackend *, KvpFrame *);
-    /*@ observer @*/
-    KvpFrame* (*get_config) (QofBackend *);
 
     gboolean (*events_pending) (QofBackend *);
     gboolean (*process_events) (QofBackend *);
@@ -318,7 +315,6 @@ struct QofBackend_s
     QofBackendError last_err;
     char * error_msg;
 
-    KvpFrame* backend_configuration;
     gint config_count;
     /** Each backend resolves a fully-qualified file path.
      * This holds the filepath and communicates it to the frontends.

diff --git a/src/libqof/qof/qofbackend.cpp b/src/libqof/qof/qofbackend.cpp
@@ -138,7 +138,6 @@ qof_backend_init(QofBackend *be)
 
     be->sync = NULL;
     be->safe_sync = NULL;
-    be->load_config = NULL;
 
     be->events_pending = NULL;
     be->process_events = NULL;
@@ -147,7 +146,6 @@ qof_backend_init(QofBackend *be)
     if (be->error_msg) g_free (be->error_msg);
     be->error_msg = NULL;
     be->percentage = NULL;
-    be->backend_configuration = kvp_frame_new();
 
     /* to be removed */
     be->price_lookup = NULL;
@@ -159,8 +157,6 @@ qof_backend_destroy(QofBackend *be)
 {
     g_free(be->error_msg);
     be->error_msg = NULL;
-    kvp_frame_delete(be->backend_configuration);
-    be->backend_configuration = NULL;
 }
 
 void