Create the GncOptionVariant's GncOptionValue in place.

Saves a temporary, prevents premature unprotecting of Scheme objects.
Gnucash · Aug 1, 2021 · f5d8d50 · f5d8d50
1 parent c034a26
commit f5d8d50
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/libgnucash/app-utils/gnc-option.cpp b/libgnucash/app-utils/gnc-option.cpp
@@ -40,8 +40,9 @@ template <typename ValueType,
 GncOption::GncOption(const char* section, const char* name,
                      const char* key, const char* doc_string,
                      ValueType value, GncOptionUIType ui_type) :
-    m_option{std::make_unique<GncOptionVariant>(GncOptionValue<ValueType> {
-            section, name, key, doc_string, value, ui_type})}
+    m_option{std::make_unique<GncOptionVariant>(
+            std::in_place_type<GncOptionValue<ValueType>>,
+            section, name, key, doc_string, value, ui_type)}
 {
 }