Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

Prometheus incorrectly handles blocks created by thanos-receiver #2

Closed
radeklesniewski opened this issue Jan 30, 2019 · 8 comments
Closed

Comments

@radeklesniewski
Copy link

radeklesniewski commented Jan 30, 2019

Hi @brancz ,

I find "thanos-receiver" idea really interesting, so I've started playing around with sending some jsons with metrics via remote-write interface to receiver. After running tests for some time I've decided to attach blocks created by receiver directly to data directory of Prometheus instance. The main problem I've spotted on Prometheus UI is that I am able to see list of metrics persisted by receiver, however when I query for any metric, Prometheus does not show any data point for particular metric.

My first idea why is it working like that was incompatibility of "prometheus/tsdb" modules. So I've updated "thanos" and "prometheus" dependencies to get it working (I've created PR with changes, not sure if I made it correctly), however the problem is still occurring. So my question is: Is it normal that blocks created by thanos-receiver won't be compatible for Prometheus? Maybe I'm missing something obvious here...

@brancz
Copy link
Contributor

brancz commented Feb 3, 2019

Sorry for not adding a readme, but this is just a proof of concept, this will be directly implemented in to the Thanos project itself. But as the patches are already ready, I'm happy to merge those :)

@brancz
Copy link
Contributor

brancz commented Feb 3, 2019

Closed by #1

@brancz brancz closed this as completed Feb 3, 2019
@radeklesniewski
Copy link
Author

I'm not sure if we understood each other correctly :) the patch with upgraded dependencies didn't resolve the issue I'm talking about. It sure is just proof of concept, however my question was whether possibility of incorrect format of blocks is something expected? Or maybe there is no reason why thanos-receiver blocks wouldn't be compatible with Prometheus?

@brancz
Copy link
Contributor

brancz commented Feb 4, 2019

Oh whops. Sorry, yes I misunderstood. Yes blocks produced by this should be valid Prometheus blocks, although most important is that it can read them itself :) (you may also need to make sure you're using the right Prometheus version).

@brancz brancz reopened this Feb 4, 2019
@rafal-dudek
Copy link

We have doubled checked the scenario, the configuration glitch was on our site. Metrics are visible in both Prometheus and Thanos Web UIs. Our setup augments thanos-receiver with thanos-sidecar (with mocked /api/v1/status/config) to transfer blocks to S3. Blocks can be used (copy pasted) to Prometheus directly too. We can close the issue.

@brancz
Copy link
Contributor

brancz commented Feb 13, 2019

Nice :) I’m currently on vacation but as soon as I’m back we will work towards getting this into main line Thanos and complete the featureset.

@brancz brancz closed this as completed Feb 13, 2019
@norbertwnuk
Copy link

Hi @brancz, any news on continuing the work? Would like to take a look / help even in case of early stages :)

@brancz
Copy link
Contributor

brancz commented Apr 1, 2019

The first pieces have been merged upstream thanos-io/thanos#811 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants