Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename crawled files to their hash to avoid duplicating files. #262

Closed
xshill opened this issue Nov 13, 2020 · 1 comment
Closed

Rename crawled files to their hash to avoid duplicating files. #262

xshill opened this issue Nov 13, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@xshill
Copy link
Collaborator

xshill commented Nov 13, 2020

At the moment, PyRDP names files crawled with its file crawler the same name as they have on the victim. To avoid duplicating files, we could name them according to their hash.

This would pose a problem since one of the file crawler's features is to recreate the remote system's file hierarchy when crawling files. However, there is a fix for that in Linux: store the file somewhere, name it after its hash, and when creating the hierarchy, create a symlink to that file. For example:

files
    - d40ea526169cb99ec8b81ff4d60ebd78
victim
    - data
        - sensitive
            - secrets.txt (symlink to d40ea526169cb99ec8b81ff4d60ebd78)

For Windows, we can't have symlinks but we could fallback to the original behaviour of saving the files without their hash.

@xshill xshill self-assigned this Nov 13, 2020
@xshill xshill added the enhancement New feature or request label Nov 13, 2020
@xshill xshill added waiting-merge A fix for this exists but hasn't been merged yet and removed waiting-merge A fix for this exists but hasn't been merged yet labels Nov 25, 2020
@xshill xshill added this to the v1.1.0 milestone Nov 26, 2020
@xshill
Copy link
Collaborator Author

xshill commented Nov 27, 2020

See issue #270

@xshill xshill closed this as completed Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant