Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log cred attempts when NLA is not used #303

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Log cred attempts when NLA is not used #303

merged 3 commits into from
Mar 18, 2021

Conversation

xshill
Copy link
Collaborator

@xshill xshill commented Mar 14, 2021

  • Handle space in password attempts
  • Log attempt when enter is pressed, not just when we receive the login PDU
  • Log attempt when the mouse is clicked in a predefined portion of the screen (currently between 50% and 65% of width and height)

@xshill xshill changed the title Cred attempts nonla Log cred attempts when NLA is not used Mar 14, 2021
obilodeau
obilodeau approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@obilodeau obilodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

pyrdp/mitm/BasePathMITM.py Show resolved Hide resolved
pyrdp/mitm/FastPathMITM.py
@@ -3,11 +3,12 @@
# Copyright (C) 2019 GoSecure Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright bump

@obilodeau obilodeau added this to the v1.1.0 milestone Mar 18, 2021
@xshill xshill merged commit f15b893 into master Mar 18, 2021
@xshill xshill mentioned this pull request Mar 25, 2021
Closed
@obilodeau obilodeau deleted the cred-attempts-nonla branch August 6, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obilodeau obilodeau obilodeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xshill @obilodeau