chore(363): replace notify2 by py-notifier #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obilodeau
reviewed
Oct 27, 2021
There was a problem hiding this comment.
Code review is ok except one note related to my overall comment which is:
I will investigate whether dbus can be removed and probably open a second PR to cleanup the dependencies.
I'd rather we do this now since this is closely related.
We should avoid unnecessary dependencies. If we don't crash when dbus is missing and notify when it is present then I think we should remove the dependency.
|
Just pinging @obilodeau in case you missed the notification. I removed all DBUS references, this should be ready for merge whenever you have time |
obilodeau
reviewed
Oct 28, 2021
obilodeau
reviewed
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces notify2 by py-notifier.
I think (but would need further testing) that this allows us to get rid of dbus dependencies since it uses
libnotify-bin. Which has been added to the README and docker files (not relevant to the CI pipeline AFAIK)I will investigate whether dbus can be removed and probably open a second PR to cleanup the dependencies.
This also paves the road to eventually supporting windows notifications once win10toast is fixed. (see jithurjacob/Windows-10-Toast-Notifications#86)
Closes #363.