Docker setup for pyrdp #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 14, 2019 11:10
The certificate cloner and the Man-in-the-middle features are both working in the docker.
Pyrdp-player is now working in a container
pyRDP can now be use with docker compose
The user in the container is no longer "root", but "developer". This simplifies the use of the pyrdp-player because the "xhost +local:docker" command is no longer required.
obilodeau
requested changes
Jan 18, 2019
General improvements have been made in the documentation and some points have been clarified
xshill
requested changes
Jan 21, 2019
The Dockerfile now takes advantage of caching. Plus, some typos have been corrected in the doc. The user in the container is now "pyrdp" instead of "developer" to simplify.
obilodeau
requested changes
Jan 23, 2019
added 3 commits
January 23, 2019 11:36
The assignment of QT_X11_NO_MITSHM is now done with the run command and explained in the README. This prevents the user from modifying the Dockerfile.
QT_X11_NO_MITSHM=1 added to the environment section
sudo was removed from all the docker commands, QT_X11_NO_MITSHM=1 was added to the run options and some minor typos were corrected in the README
xshill
reviewed
Jan 25, 2019
-The run command example in the README is more explicit. -The build command now uses the image name.
|
@xshill can you take another look when you have a minute? |
Corrections of the README so the installation commands are more specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.