You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've built a little command-line passphrase generator, and added your library in to calculate entropy for the generated passwords. I've noticed when I try to run multiple estimations in parallel with the same object, I get one of many kinds of errors:
ConcurrentModificationException
java.lang.IllegalStateException: There was an unexpected error and all of the matches put together do not equal the original password.
Entropy of 0.0
Can you chime in on whether this object is thread-safe?
Thanks!
The text was updated successfully, but these errors were encountered:
I tested the library with Apache Benchmark and came to same conclusion.
The generateMatches method is not thread safe due to the presence of class variables.
I've created a pull request to fix this (see #49)
I just merged the PR, and am working on adding some concurrency tests to fix this going forward. Thanks raising the issue @coreagile, and thank you @robin-maxxton for the work on this!
I've built a little command-line passphrase generator, and added your library in to calculate entropy for the generated passwords. I've noticed when I try to run multiple estimations in parallel with the same object, I get one of many kinds of errors:
Can you chime in on whether this object is thread-safe?
Thanks!
The text was updated successfully, but these errors were encountered: